1281730 - Workers and setTimeout ⇒ "Assertion failure: !IsNull() (Cannot compute with a null value)" within nsGlobalWindow::InsertTimeoutIntoList

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: !IsNull() (Cannot compute with a null value), at TimeStamp.h:551

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Andrew Overholt [:overholt]]

Ben, WDYT about this assertion?

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

I haven't really looked at this yet, but I can tell you opening the attached test case leaks its window.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Restore timeouts before thawing workers to avoid running script on frozen timers. r=khuey

So the issue here is that the timers were suspended on the window.  In nsGlobalWindow::ResumeTimers() we thaw workers and then fixup the timer instances.  With this test case, though, there is a pending message event from the worker which immediately calls setTimeout().  This then blows up because the timer objects still are in their frozen state with mValues of 0.

I think the safest thing to do here is to simply restore the timers before thawing the workers.  Any timer initialized in this process should run in a new runnable on the main thread and therefore won't execute before the worker thaw process.

I also considered making the worker thaw process asynchronous, but there are comments about strict ordering of the frozen events vs the worker thread running, so that did not seem as safe.

This patch fixes the issue locally for me.  I'll do a try run next to verify it doesn't break something else.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c3886aa3b96

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98f89b579438
Restore timeouts before thawing workers to avoid running script on frozen timers. r=khuey

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/98f89b579438