Closed Bug 1281750 Opened 5 years ago Closed 5 years ago
Marionette should include current application process id in capabilities
58 bytes, text/x-review-board-request
As part of my work to fix bug 1276220 we would need a way to let Marionette client know about the new process id of Firefox in case of restarts of Firefox, and when it spawns itself in a new process group. Given that Firefox knows about its process id and we can retrieve it via appinfo it's easy to get it over to the client. This bug only covers the Marionette server side and I think that this code could remain here forever, while for the client we would need a workaround until bug 1176758 has been fixed in a meaningful way.
Review commit: https://reviewboard.mozilla.org/r/60356/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/60356/
Attachment #8764539 - Flags: review?(dburns)
Comment on attachment 8764539 [details] Bug 1281750 - Marionette should include current application process id in capabilities. https://reviewboard.mozilla.org/r/60356/#review57230
Attachment #8764539 - Flags: review?(dburns) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/f0110950e76f Marionette should include current application process id in capabilities. r=automatedtester
I’m against this change because the process that spawns Firefox already should know the PID.
Andreas, I would suggest that you read the referenced bug first. In short, due to restarts of Firefox the client can loose the pid of Firefox.
It's a testing only change which we would also have to backport on mozilla-aurora.
You need to log in before you can comment on or make changes to this bug.