Closed Bug 1281750 Opened 3 years ago Closed 3 years ago

Marionette should include current application process id in capabilities

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox49 fixed, firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

As part of my work to fix bug 1276220 we would need a way to let Marionette client know about the new process id of Firefox in case of restarts of Firefox, and when it spawns itself in a new process group.

Given that Firefox knows about its process id and we can retrieve it via appinfo it's easy to get it over to the client.

This bug only covers the Marionette server side and I think that this code could remain here forever, while for the client we would need a workaround until bug 1176758 has been fixed in a meaningful way.
Comment on attachment 8764539 [details]
Bug 1281750 - Marionette should include current application process id in capabilities.

https://reviewboard.mozilla.org/r/60356/#review57230
Attachment #8764539 - Flags: review?(dburns) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0110950e76f
Marionette should include current application process id in capabilities. r=automatedtester
I’m against this change because the process that spawns Firefox already should know the PID.
Andreas, I would suggest that you read the referenced bug first. In short, due to restarts of Firefox the client can loose the pid of Firefox.
https://hg.mozilla.org/mozilla-central/rev/f0110950e76f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
It's a testing only change which we would also have to backport on mozilla-aurora.
Whiteboard: [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.