128177 - [FIX]Gzipped postscript files unzipped when saved but extension left as .ps.gz

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Robin Green]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.8+) Gecko/20020227
BuildID:    2002022700

Gzipped postscript files are transparently ungzipped when downloaded, but the
file extension is not changed from .ps.gz to .ps. This applies to postscript
files but not e.g. tar files.

Reproducible: Always
Steps to Reproduce:
1. Disable any handler apps for postscript
2. Go to URL above
3. Choose Save


Actual Results:  File saved as n843.ps.gz, but it has been gunzipped by mozilla.

Expected Results:  File should be saved as n843.ps.gz and should be still
gzipped up.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Should be fixed by the checkin to bug 69306.  see bug 121001.  Can you try a
later build?  That build ID looks like a self built Moz, which might not have
picked up the patch... 

Comment 2

[Boris Zbarsky [:bzbarsky]]

No, this is _caused_ by the fix for bug 69306.  I _thought_ I should have added
postscript to the ban list....

Taking bug.

Comment 3

[Boris Zbarsky [:bzbarsky]]

taking for real

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

So... the site sends the file as application/x-gunzip.	The patch adds that to
the nsHttpChannel "apache is broken" logic and adds postscript to the list of
types not to decode (a good idea anyway, imo).

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 71815 [details] [diff] [review]
Proposed fix

x-gunzip? Who comes up with these?

r=bbaetz

Comment 6

[Darin Fisher]

Comment on attachment 71815 [details] [diff] [review]
Proposed fix

sr=darin

Comment 7

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 71815 [details] [diff] [review]
Proposed fix

a=shaver for 0.9.9.

Comment 8

[Boris Zbarsky [:bzbarsky]]

fix checked in

Comment 9

[Boris Zbarsky [:bzbarsky]]

To be clear, this was checked in for 0.9.9, pre-branch.

Comment 10

[sairuh (rarely reading bugmail)]

vrfy'd fixed using test case in comment 0 (linux rh7.2, 2002.07.23.06-1.0).