1281777 - Top sites is not displayed when tapping the URL Bar on a new tab with homepage

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

version 5.0 (1)
Steps to reproduce:
1. Go to settings and set a homepage
2. Set New Tab to "Show your Homepage"
3. Open a new tab
4. Tap the URL Bar

Expected results:
- about:home is displayed

Actual results:
- The page is displayed in edit mode

Comment 1

[Aaron Train [:aaronmt]]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #0)
> version 5.0 (1)
> Steps to reproduce:
> 1. Go to settings and set a homepage

I set my homepage to http://reddit.com

> 2. Set New Tab to "Show your Homepage"
> 3. Open a new tab

I get http://reddit.com

> 4. Tap the URL Bar

The URL is editable

> Expected results:
> - about:home is displayed
> 
> Actual results:
> - The page is displayed in edit mode

What am I missing? I can't reproduce. Why would about:home be displayed if I set a custom homepage to a site.

Comment 2

[Aaron Train [:aaronmt]]

Actually never-mind, I misunderstood. We should be showing the panels, otherwise the only access to them is via the me menu button shortcuts.

Comment 3

[Bryan Munar (:bkmunar)]

so speaking with tecgirl about this, I'm assuming that you implemented to not show about:home on url taps for blank pages and homepages? If so and if that's part of the plan, I'll leave it to tecgirl to come in with the final say to see if that needs to be changed. If it needs to be changed, I think it's a simple 1-3 liner right?

Comment 4

[James Hugman [:jhugman] [@jhugman]]

The new tab behaviour is fairly under-specced. 

My reasoning for new tab as: 

blank: tapping on the URL bar was the only action that makes sense after opening the new tab. If this is automatic, and the homepanels are displayed, this is indistinguishable from the previous behaviour.

homepage: the homepage is more like a web page than a home panel, and the URL should be editable. Much less clear reasoning for why this shouldn't bring up the Home panel when tapping on the URL bar.

> If it needs to be changed, I think it's a simple 1-3 liner right?
Correct.

Relevant line is: https://github.com/mozilla/firefox-ios/blob/0af1065d0f1016ade7e45b40b3d27cd27c27b6cb/Client/Frontend/Browser/BrowserViewController.swift#L1537

Comment 5

[Brian Nicholson (:bnicholson)]

This does feel kinda funky. What's the use case for "Show a Blank Page"? Can we just remove that option altogether?

Comment 6

[Bryan Munar (:bkmunar)]

will wait for tecgirl to respond - i think she's flying rn.

Comment 7

[Robin Andersen [:tecgirl]]

about:home should only be displayed when tapping the Home icon. no changes should be made to the current behavior when you tap on the URLbar.

Comment 8

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 9

[James Hugman [:jhugman] [@jhugman]]

:bkmunar: 

< if [.HomePage, .BlankPage].contains(NewTabAccessors.getNewTabPage(profile.prefs))
> if .BlankPage == NewTabAccessors.getNewTabPage(profile.prefs)

Current PR means that 'Show a Blank Page' does exactly the same as 'Show Top Sites', but for a tap. (i.e. a worse experience than Show Top Sites).

Blank page is a requirement from :dxue btw.

Comment 10

[Bryan Munar (:bkmunar)]

I think that's the behavior :tecgirl wants, but waiting for her confirmation/review

Comment 11

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8766857 [details] [review]
PR

https://shipitsquirrel.github.io/

Comment 12

[Bryan Munar (:bkmunar)]

https://github.com/mozilla/firefox-ios/pull/1978/commits/2f3571807a55ee45188f334cc450ef5a640233b9

Comment 13

[Stephan Leroux [:sleroux]]

v5.x c348e81

Comment 14

[Catalin Suciu [:csuciu]]

Verifying as fixed on build 5.0(2)

about:home is displayed when following the steps from comment #0

Comment 15

[Stephan Leroux [:sleroux]]

Looks like this was been resolved and already uplifted. Removing needs uplift.