Closed
Bug 1281866
Opened 8 years ago
Closed 8 years ago
Rename gUM's SourceUnavailableError to NotReadableError.
Categories
(Core :: WebRTC: Audio/Video, defect, P2)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: jib, Assigned: jib)
References
()
Details
Attachments
(2 files)
Follow spec change.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/60400/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/60400/
Attachment #8764685 -
Flags: review?(padenot)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jib
Updated•8 years ago
|
Priority: -- → P2
Comment 2•8 years ago
|
||
Comment on attachment 8764685 [details] Bug 1281866 - Rename gUM's SourceUnavailableError to NotReadableError. https://reviewboard.mozilla.org/r/60400/#review57602 Do we have tests for this?
Attachment #8764685 -
Flags: review?(padenot) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/60824/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/60824/
Attachment #8765473 -
Flags: review?(padenot)
Comment 4•8 years ago
|
||
Comment on attachment 8765473 [details] Bug 1281866 - Test gUM's NotReadableError. https://reviewboard.mozilla.org/r/60824/#review57656
Attachment #8765473 -
Flags: review?(padenot) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8765473 [details] Bug 1281866 - Test gUM's NotReadableError. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60824/diff/1-2/
Assignee | ||
Comment 6•8 years ago
|
||
Forgot I need to set fake: true explicitly on linux to get the internal default devices rather than the loopback test devices there. Doing a try run. Carrying forward r=padenot.
Pushed by jbruaroey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e5a344d0bcd8 Rename gUM's SourceUnavailableError to NotReadableError. r=padenot https://hg.mozilla.org/integration/mozilla-inbound/rev/3f8b0c4ea602 Test gUM's NotReadableError. r=padenot
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e5a344d0bcd8 https://hg.mozilla.org/mozilla-central/rev/3f8b0c4ea602
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•