1281901 - Swift 2.3 Migration

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect, P1)

Description

[Stephan Leroux [:sleroux]]

Meta bug tracking migration progress of Firefox for iOS to Swift 2.3

Comment 1

[Stephan Leroux [:sleroux]]

So running the code migrator only shows a few files that need to be changed in Shared but thats it for moving to 2.3. The bigger problem are some of our dependencies:

SnapKit's 2.3 branch is failing to build on Carthage but should be fixed soon since it's a pretty active project.

XCGLogger might need some work to convert to Swift 2.3 since there hasn't been any update from the author yet. Project isn't large so it shouldn't be a problem if we need to

SwiftKeychainWrapper hasn't started a 2.3 branch but is somewhat active so we might see a 2.3 branch soon. If needed, the project is small so converting it to 2.3 won't be bad.

Other than that all other Swift dependencies have 2.3 branches in flight so I don't see too many issues considering the jump from 2.2->2.3 is pretty minimal.

Comment 2

[Stephan Leroux [:sleroux]]

WIP branch: https://github.com/mozilla/firefox-ios/pull/1942

See PR comments for updates:

TL;DR: Just need to update our code with the recent Alamofire changes and we should be good to go in Xcode 8.

Comment 3

[Stephan Leroux [:sleroux]]

If you're looking to use Carthage to build the dependencies using Xcode 8,

1. Download Xcode 8 GM
2. Switch the toolchain Carthage uses to build with by using 'sudo xcode-select -s <path to Xcode 8 GM>'
3. Make sure you remove your Carthage/ and Cartfile.resolve files prior to ./bootstrap'ing

Comment 4

[Brian Nicholson (:bnicholson)]

Taking a look at this now. Unfortunately, as I go through and fix these Alamofire errors, it unlocks a lot more errors like the ones fixed in the linked branch, so it's difficult to judge exactly how close we are to completion.

Comment 5

[Stephan Leroux [:sleroux]]

I had a feeling there was a can of worms being opened =( If there is anything you want help with feel free to let me know. I'll go ahead and assign this to you.

Comment 6

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1942

Rebased and updated. There turned out to be a ton of other fixes needed after the Alamofire changes, but things seem to be building now.

There's one new API change that I wasn't quite sure how to resolve -- see PR.

Comment 7

[Stephan Leroux [:sleroux]]

Comment on attachment 8791809 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1942

Looks good! Excited to start using Xcode 8 =)

Comment 8

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/a0f3f70109a73bd517513be47247cbbe9812f5c4