Email opt in form does not appear for Spanish versions of account creation form

RESOLVED FIXED

Status

Cloud Services
Server: Firefox Accounts
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Ben Niolet, Assigned: stomlinson)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fxa], URL)

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8764710 [details]
Screen Shot 2016-06-23 at 3.11.13 PM.png

The email opt-in checkbox does not appear on Spanish language versions of the Account creation page. Likewise, Spanish language preference menu does not allow users to change their subscription preferences. 

We discovered in testing the new CRM setup that if the browser's language is set to any Spanish language (ex: es-es, es-mx, etc.) the opt-in checkbox does not show. 

The box appears and works correctly for other languages supported by email (RU, DE, PT-BR, etc., but not Spanish).
(Reporter)

Comment 1

2 years ago
In Bug 1179873, we integrated the accounts creation form to allow email opt-ins for languages other than English. 

https://bugzilla.mozilla.org/show_bug.cgi?id=1179873
(Reporter)

Comment 2

2 years ago
Created attachment 8764711 [details]
Polish form screen shot (for reference)

Just for comparison, other languages do have the check box available.
From the list here:

  https://github.com/mozilla/fxa-content-experiments/blob/dev/communication-prefs/communication-prefs.js#L12

It looks like the form is enabled for the base "es" locale, but not for any of the (many!) region-specific tags.  Should we add a `es-[a-z]{2}` rule to match any Spanish locale, similar to the existing `en-[a-z]{2}` rule that matches any English locale?
Flags: needinfo?(bniolet)
(Reporter)

Comment 4

2 years ago
I can confirm that if you set your language to just "es" you get the form. 

Knowing what I know about the Lat-Am / Es-Es communities though, no one will make that their language. I think a regex would be just perfect to solve this.
Flags: needinfo?(bniolet)
(Assignee)

Updated

2 years ago
Whiteboard: [fxa]
(Assignee)

Updated

2 years ago
(Assignee)

Comment 5

2 years ago
Issued a pull request to the fxa-content-experiments repo here: https://github.com/mozilla/fxa-content-experiments/pull/38
Assignee: nobody → stomlinson
Status: NEW → ASSIGNED
Thanks, Shane. Do you have an ETA for this to go live?
Flags: needinfo?(stomlinson)
(Assignee)

Comment 7

a year ago
A new train with this feature should go into production sometime this week. Shifting the ni to :jrgm and :jbuck who are in charge of our deployments.
Flags: needinfo?(stomlinson)
Flags: needinfo?(jrgm)
Flags: needinfo?(jbuckley)

Updated

a year ago
Depends on: 1286449
Thanks, Shane!

:jrgm & :jbuck - did this go live last week?
Created attachment 8774806 [details]
Screenshot 2016-07-26 12.56.58.png

Yep, this is working correctly now
Flags: needinfo?(jrgm)
Flags: needinfo?(jbuckley)
(Reporter)

Comment 10

a year ago
Hi guys. I tested this and there's no email opt in check box on the form for any es-xx language. So es-cl or es-py the page has no check box. If you set the browser language to just "es" there is a check box. 

Am I missing something? Am I supposed to test this in a staging environment or is it supposed to be live? 

Steps to reproduce

1) launch Firefox profile manager. 

2) Create a blank profile. 

3) Start Firefox with the new profile. 

4) In Preferences > Content, set the first language to es-py or es-mx or anything es-xx. 

5) navigate to accounts.firefox.com. 

6) The accounts page will not have an email opt-in box.
Flags: needinfo?(jrgm)
Flags: needinfo?(jbuckley)
(Assignee)

Comment 11

a year ago
When I test locally with es-AR, the box shows up correctly. This leads me to believe the wrong sha is being used for fxa-content-experiments on prod. The last branch is is `train-64` with sha 07922dc8021ec349e80e846273743923aa6ffdba, created on June 3rd. We need sha a1f8d718d545fe6782f7c4009562a727e6418768, created on June 30th.

Keeping the ni for jbuck and jrgm.
This new commit came along with train-67, which just shipped. I tested with es and es-MX and confirmed that I get the opt-in checkbox for both now. Ben, want to confirm?
Depends on: 1293933
No longer depends on: 1286449
Flags: needinfo?(jrgm)
Flags: needinfo?(jbuckley)
(Reporter)

Comment 13

a year ago
Just checked with es-cl (Chile). 

It worked!! I'm confirming this is fixed.

Updated

a year ago
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.