1281955 - Don't Adopt() NSS allocated strings in PSM to avoid using the wrong deallocator

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

There are a few places in PSM where the result of an NSS function returning char* is adopted by e.g. an nsXPIDLCString, which will use the wrong deallocator when the string eventually gets destroyed.

This is basically Bug 1281564, but the free() call is buried within the Mozilla string code instead.

Here's an example (https://hg.mozilla.org/mozilla-central/file/d9659c22b3c5/security/manager/ssl/nsNSSCertificateDB.cpp#l383):
> nsXPIDLCString nickname;
> nickname.Adopt(CERT_MakeCANickname(tmpCert.get()));

Comment 1

[:Cykesiopka]

Attachment: Bug 1281955 - Don't Adopt() NSS allocated strings in PSM to avoid using the wrong deallocator.

There are a few places in PSM where the result of an NSS function returning
char* is adopted by e.g. an nsXPIDLCString, which will use the wrong deallocator
when the string eventually gets destroyed.

This is basically Bug 1281564, but the free() call is buried within the Mozilla
string code instead.

Review commit: https://reviewboard.mozilla.org/r/61436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61436/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8766639 [details]
Bug 1281955 - Don't Adopt() NSS allocated strings in PSM to avoid using the wrong deallocator.

https://reviewboard.mozilla.org/r/61436/#review58480

Cool - r=me

Comment 3

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=708f96def76f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8e3ba3674f7
Don't Adopt() NSS allocated strings in PSM to avoid using the wrong deallocator. r=dkeeler

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b8e3ba3674f7