1281968 - YouCompleteMe not seeing language version flags

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Ralph Giles (:rillian)]

Today I noticed Ycm was marking up C++11-only features in my source files, like the `auto` keyword and `F foo = {a, b, c}` struct initializers.

We generally build with `-std=gnu++11` but it looks like .ycm_extra_conf.py isn't getting this flag from mach.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Workaround

Here's a work-around patch, just forcing the flag unconditionally. Presumedly this breaks Ycm on non-C++ source files.

Ehsan, and idea what's going on here?

Comment 2

[(no longer active)]

So sorry for the long delay here, I was on vacation/sick...

So the way that this works is .ycm_extra_conf.py calls |./mach compileflags path/to/file.cpp| which in turn runs |make -C objdir/path/to showbuild|.  Running the showbuild target manually, I get:

                  CC =  /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/clang -std=gnu99
                 CXX =  /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/clang++ -std=gnu++11
                 CCC =  /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/clang++ -std=gnu++11
                 CPP = /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/clang -std=gnu99 -E
...

Note how the -std flags are specified in CXX and not CXXFLAGS!

Comment 3

[(no longer active)]

Attachment: Include the flags passed through CC/CXX in ./mach compileflags

Comment 4

[(no longer active)]

Comment on attachment 8764789 [details] [diff] [review]
Workaround

My patch fixes this more properly.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a1c5b06f3da
Include the flags passed through CC/CXX in ./mach compileflags; r=gps

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a1c5b06f3da

Comment 7

[Ralph Giles (:rillian)]

Thanks ehsan!