1282004 - Convert TestMD4 CPP unit test into a GTest

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

Nothing in the file requires functionality provided by the CPP unit test harness, so making the file a GTest makes it more accessible.

Comment 1

[:Cykesiopka]

Attachment: Bug 1282004 - Make it easier to run all PSM GTests at once.

Currently, running all the PSM GTests involves providing a filter that catches
all the various tests. This is annoying and error prone.

The changes here make running all PSM GTests as easy as:
  mach gtest "psm*"

Review commit: https://reviewboard.mozilla.org/r/60838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60838/

Comment 2

[:Cykesiopka]

Attachment: Bug 1282004 - Convert TestMD4 CPP unit test into a GTest.

Nothing in the file requires functionality provided by the CPP unit test harness,
so making the file a GTest makes it more accessible.

Review commit: https://reviewboard.mozilla.org/r/60840/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60840/

Comment 3

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8765501 [details]
Bug 1282004 - Make it easier to run all PSM GTests at once.

https://reviewboard.mozilla.org/r/60838/#review58144

Comment 4

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8765502 [details]
Bug 1282004 - Convert TestMD4 CPP unit test into a GTest.

https://reviewboard.mozilla.org/r/60840/#review58146

Comment 5

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a481388d46ec

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80a6a5d46260
Make it easier to run all PSM GTests at once. r=mgoodwin
https://hg.mozilla.org/integration/mozilla-inbound/rev/731d8d633db8
Convert TestMD4 CPP unit test into a GTest. r=mgoodwin

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/80a6a5d46260
https://hg.mozilla.org/mozilla-central/rev/731d8d633db8