Adjust the "scalars" format in the main ping

RESOLVED FIXED in Firefox 50

Status

()

defect
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Dexter, Assigned: Dexter)

Tracking

(Blocks 1 bug)

Trunk
mozilla50
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [measurement:client])

Attachments

(1 attachment, 1 obsolete attachment)

The scalars are landing, but no consensus was reached on the right format to store parent/content data in bug 1281795.

This bug is about fixing the format depending on the outcome of bug 1281795.
Blocks: 1275517
Depends on: 1281795
Whiteboard: [measurement:client]
Priority: -- → P2
Bug 1281795 has an agreed-upon format, so lets do this for scalars now.
Priority: P2 → P1
Assignee: nobody → alessio.placitelli
Posted patch bug1282091.patch (obsolete) — Splinter Review
Attachment #8767672 - Flags: review?(gfritzsche)
Comment on attachment 8767672 [details] [diff] [review]
bug1282091.patch

Review of attachment 8767672 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetrySession.jsm
@@ +1282,3 @@
>      // Notify that there was a subsession split in the parent process.
>      if (isSubsession && clearSubsession) {
>        Services.obs.notifyObservers(null, "telemetry-subsession-split", "");

Nit: I would stack the changes the other way around.
That way we never have a real usage of the previous format landed.
Attachment #8767672 - Flags: review?(gfritzsche) → review+
Attachment #8767672 - Attachment is obsolete: true
Status: NEW → ASSIGNED
(In reply to Georg Fritzsche [:gfritzsche] [away Jun 24 - Jul 3] from comment #3)
> Comment on attachment 8767672 [details] [diff] [review]
> bug1282091.patch
> 
> Review of attachment 8767672 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/components/telemetry/TelemetrySession.jsm
> @@ +1282,3 @@
> >      // Notify that there was a subsession split in the parent process.
> >      if (isSubsession && clearSubsession) {
> >        Services.obs.notifyObservers(null, "telemetry-subsession-split", "");
> 
> Nit: I would stack the changes the other way around.
> That way we never have a real usage of the previous format landed.

Good point. I've rebased the patch and also dealt with about:telemetry, which was still using the old format.
Points: --- → 1
This needs documentation - follow-up bug?
Flags: needinfo?(alessio.placitelli)
Depends on: 1284572
Filed bug 1284572.
Flags: needinfo?(alessio.placitelli)
https://hg.mozilla.org/mozilla-central/rev/55e734798239
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Can you submit a PR to the pipeline schemas?
Flags: needinfo?(alessio.placitelli)
There we go: https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/9
Flags: needinfo?(alessio.placitelli)
You need to log in before you can comment on or make changes to this bug.