1282209 - We should run imgFrame::Optimize off-main-thread

Status: RESOLVED INVALID

(Core :: Graphics: ImageLib, task, P3)

Description

[Seth Fowler [:seth] [:s2h]]

There are two reasons why we need to start running imgFrame::Optimize off-main-thread:

(1) Doing more work off-main-thread is good.

(2) Because we have to do it on-main-thread, we can't wait for it when we need to draw, which means that when there are rendering differences between the optimized and non-optimized version of the image (and there frequently are), we have to mark massive numbers of tests fuzzy, because whether we end up with the optimized or unoptimized version is a race. Indeed, this has already happened. See bug 1128229 for an example.

It's unclear to me, after poking around in the Moz2D code that gets called (which is where the problems, if any, would lie) whether this is even difficult at this point. Let's get it figured out.

Comment 1

[Andrey Bienkowski]

https://bugzilla.mozilla.org/show_bug.cgi?id=1548706

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:aosmond, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

This bug is no longer valid with WR.