1282212 - Preview imports and opening calendar files so user can confirm

Status: NEW

(Calendar :: Import and Export, enhancement, P5)

Description

[ISHIKAWA, Chiaki]

Environment
C-C TB (local build): 50.0a1 (2016-06-25)
Lightning:            5.2a1

(I have use this version of lightning since the
version available through ordinary search addon feture can't work with
50.0a1 (C-C) tree.

Current behavior:

TB with lightning automatically, WITHOUT ANY USER INTERVENTION,
import an event (or events?) in an ics file when it opens
such a file via the menubar 
[File] -> [Open] -> [calendar file] path.

This is bad. A user cannot see what is inside the file.
It may have an unwanted series of event, etc.

Suggested behavior"

Before importing the event, there should be a visible dialog
that shows the contents of the event (time, date, who is proposing it, etc. AND TB+lightning should let the user select [import] or [cancel].


A calendar event file attached to an e-mail DOES HAVE SUCH
FEEDBACK DIALOG so that we know what event we are registering in our calendar(s).
We should do SIMILARLY when we open a calenar file.
(Right, today's "open" is not actually "opening a calendar file so that we can take a look inside."

TIA

PS: This could be used by someone with a malicious to harass unsuspecting users.

Imagine someone creates an ICS that contains derogatory remarks and that seems to originate from someone.
Just leave it on a shared file system and
somebody clicks by intention or by mistake.
The derogatory remark may be registered in an office calendar in someone's name.
It will be an embarrassing experience for people whose name may appear in such malicious event (title, description, etc.).

Having a dialog to confirm the content of a calendar file keeps such incidents from happening greatly.

Look, the e-mail event file attachment is already handled with care.
We should handle what a human user cannot grok without machine intervention with care. (Nobody outside developer community would read an ics file with text editor and confirm the content before importing it via TB in one step. We should show a dialog with the clear display of event as is done with event notice that comes in an email before the decision to import is made.)

Comment 1

[[:MakeMyDay]]

When using [File] -> [Open] -> [calendar file], the content of the calendar file (which may be a single item or multiple) is not imported in any existing calendar. Instead, a new calendar subscription to that file is created which shows up as separate calendar in the calendar list. So, a user can easily inspect the items using the existing calendar view/dialog (including moving the event to a different calendar of choice).

Importing in an existing calendar is a different operation that is available at [Events and Tasks] -> [Import] and is intended and from a user's perspective also expected as a batch operation without further user interaction except of selecting source and target.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

As mentioned, specifically for File > Open > Calendar, it is easy to just unsubscribe from the calendar again. This is of course not the case for import. An import/open preview would definitely be a great enhancement. Care should be taken with the presentation though. Calendars may have a large number of events, not just one like the invitation panel.

Comment 3

[Stefan Sitter [:ssitter]]

Well, the 'open' feature basically is a preview for the 'import' feature. If you like what you see in the opened calendar just keep the new calendar or remove it and import into an existing calendar.

Comment 4

[ISHIKAWA, Chiaki]

(In reply to [:MakeMyDay] from comment #1)
> When using [File] -> [Open] -> [calendar file], the content of the calendar
> file (which may be a single item or multiple) is not imported in any
> existing calendar. Instead, a new calendar subscription to that file is
> created which shows up as separate calendar in the calendar list. So, a user
> can easily inspect the items using the existing calendar view/dialog
> (including moving the event to a different calendar of choice).

Thank you for the clarification. I must have missed subtle difference, but
still seeing something alien thing that 
"shows up as separate calendar" even before a user has a chance for inspection
did not seem right to me.
At least, in the case of email notification, one is ASKED to see what one wants to do.
 
> Importing in an existing calendar is a different operation that is available
> at [Events and Tasks] -> [Import] and is intended and from a user's
> perspective also expected as a batch operation without further user
> interaction except of selecting source and target.

I see. Does it show the content just in case for user confirmation?

I think I need to get used to calendar: it is RELATIVELY new for MANY users, I think.
(I know it has been around for a long time, but until it became part of the official TB distribution [not an option], not many people seem to have used it.]
I only have used office-wide calendar and not sure how I will manage the local/shared calendar in such a setting.

Comment 5

[ISHIKAWA, Chiaki]

(In reply to Stefan Sitter from comment #3)
> Well, the 'open' feature basically is a preview for the 'import' feature. If
> you like what you see in the opened calendar just keep the new calendar or
> remove it and import into an existing calendar.

But I did not see ANY chance for a feedback for the "open"ed ([File] -> [Open] -> [calendar file]"). That is there was no "what you see in the opened calendar".
Nothing was visible.