1282218 - nss 3.23 cannot be built on PPC Mac OS X 10.4.11, Tiger

Status: RESOLVED INCOMPLETE

(NSS :: Build, defect)

Description

[Peter Dyballa]

What did you do?
================
1. Try to install nss with MacPorts
2. See and report the bug to MacPorts
3. Try to understand and fix the bug

What happened?
==============
Compiler Clang MP version 3.3 reports:

/opt/local/bin/clang-mp-3.3 -arch ppc -o Output.OBJD/Darwin_SINGLE_SHLIB/pqg.o -c -Os -fPIC -Dppc -fno-common -pipe -DDARWIN -DHAVE_STRERROR -DHAVE_BSD_FLOCK  -Wall -Qunused-arguments -Wno-parentheses-equality -Wno-array-bounds  -Werror -DXP_UNIX -DSHLIB_SUFFIX=\"dylib\" -DSHLIB_PREFIX=\"lib\" -DSHLIB_VERSION=\"3\" -DSOFTOKEN_SHLIB_VERSION=\"3\" -DRIJNDAEL_INCLUDE_TABLES -UDEBUG -DNDEBUG -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DMP_API_COMPATIBLE -I/opt/local/include/nspr -I../../../dist/Output.OBJD/include -I../../../dist/public/nss -I../../../dist/private/nss -Impi -Iecl  pqg.c
pqg.c:339:16: error: comparison of constant 18446744073709551615 with expression of type 'unsigned long' is always true [-Werror,-Wtautological-constant-out-of-range-compare]
    if (addend < MP_DIGIT_MAX) {
        ~~~~~~ ^ ~~~~~~~~~~~~
1 error generated.
make[3]: *** [Output.OBJD/Darwin_SINGLE_SHLIB/pqg.o] Error 1
make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_net_nss/nss/work/nss-3.23/nss/lib/freebl'

After fixing that with:

--- nss/lib/freebl/pqg.c-orig   2016-02-26 21:51:11.000000000 +0100
+++ nss/lib/freebl/pqg.c        2016-06-25 10:29:36.000000000 +0200
@@ -320,8 +320,8 @@
 
 static SECStatus
 addToSeed(const SECItem * seed, 
-          unsigned long   addend,
-          int             seedlen, /* g in 186-1 */
+          unsigned long long  addend,
+          int                 seedlen, /* g in 186-1 */
           SECItem * seedout)
 {
     mp_int s, sum, modulus, tmp;

A new error came up:

/opt/local/bin/clang-mp-3.3 -arch ppc -o Output.OBJD/Darwin_SINGLE_SHLIB/ecl_gf.o -c -Os -fPIC -Dppc -fno-common -pipe -DDARWIN -DHAVE_STRERROR -DHAVE_BSD_FLOCK  -Wall -Qunused-arguments -Wno-parentheses-equality -Wno-array-bounds  -Werror -DXP_UNIX -DSHLIB_SUFFIX=\"dylib\" -DSHLIB_PREFIX=\"lib\" -DSHLIB_VERSION=\"3\" -DSOFTOKEN_SHLIB_VERSION=\"3\" -DRIJNDAEL_INCLUDE_TABLES -UDEBUG -DNDEBUG -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DMP_API_COMPATIBLE -I/opt/local/include/nspr -I../../../dist/Output.OBJD/include -I../../../dist/public/nss -I../../../dist/private/nss -Impi -Iecl  ecl/ecl_gf.c
/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_net_nss/nss/work/.tmp/ecl_gf-Ll1z35.s:852:Parameter error: r0 not allowed for parameter %lu (code as 0 not r0) (parameter 2)
/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_net_nss/nss/work/.tmp/ecl_gf-Ll1z35.s:906:Parameter error: r0 not allowed for parameter %lu (code as 0 not r0) (parameter 2)
clang: error: assembler (via gcc) command failed with exit code 1 (use -v to see invocation)
make[3]: *** [Output.OBJD/Darwin_SINGLE_SHLIB/ecl_gf.o] Error 1
make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_net_nss/nss/work/nss-3.23/nss/lib/freebl'


What should have happened?
==========================
Compilation and build,

Is there anything else we should know?
======================================
See https://trac.macports.org/ticket/51196 and https://trac.macports.org/ticket/51709.

Comment 1

[Franziskus Kiefer [:franziskus]]

Please re-open if the issue still exists with the latest NSS version.