Closed Bug 1282222 Opened 5 years ago Closed 5 years ago

Fennec should trigger `notificationclose` events

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: sunhaitao, Assigned: sunhaitao)

References

Details

Attachments

(3 files)

Currently, no event is triggered when a persistent notification is closed on Android.
Assignee: nobody → sunhaitao
Depends on: 1264815, 1265841
Target Milestone: --- → Firefox 50
Review commit: https://reviewboard.mozilla.org/r/60740/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60740/
Attachment #8765273 - Flags: review?(nchen)
Attachment #8765274 - Flags: review?(nchen)
Attachment #8765275 - Flags: review?(kcambridge)
Attachment #8765275 - Flags: review?(kcambridge) → review+
Comment on attachment 8765275 [details]
Bug 1282222 - Make the PersistentNotificationHandler handle 'persistent-notification-close' ;

https://reviewboard.mozilla.org/r/60744/#review57612

Great!
Comment on attachment 8765273 [details]
Bug 1282222 - Clean up 'NotificationClient.java' ;

https://reviewboard.mozilla.org/r/60740/#review57852
Attachment #8765273 - Flags: review?(nchen) → review+
Comment on attachment 8765274 [details]
Bug 1282222 - Add a 'deleteIntent' parameter to the 'NotificationClient.add' method ;

https://reviewboard.mozilla.org/r/60742/#review57850
Attachment #8765274 - Flags: review?(nchen) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/4d1756f10acc
Clean up 'NotificationClient.java' ;r=jchen
https://hg.mozilla.org/integration/fx-team/rev/e68faf07dda2
Add a 'deleteIntent' parameter to the 'NotificationClient.add' method ;r=jchen
https://hg.mozilla.org/integration/fx-team/rev/3ce3be36f582
Make the PersistentNotificationHandler handle 'persistent-notification-close' ;r=kitcambridge
Keywords: checkin-needed
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.