Closed
Bug 1282222
Opened 8 years ago
Closed 8 years ago
Fennec should trigger `notificationclose` events
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox50 fixed)
RESOLVED
FIXED
Firefox 50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: sunhaitao, Assigned: sunhaitao)
References
Details
Attachments
(3 files)
Currently, no event is triggered when a persistent notification is closed on Android.
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/60740/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/60740/
Attachment #8765273 -
Flags: review?(nchen)
Attachment #8765274 -
Flags: review?(nchen)
Attachment #8765275 -
Flags: review?(kcambridge)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/60742/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/60742/
|
|
Assignee | |
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/60744/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/60744/
|
||
Updated•8 years ago
|
Attachment #8765275 -
Flags: review?(kcambridge) → review+
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8765275 [details] Bug 1282222 - Make the PersistentNotificationHandler handle 'persistent-notification-close' ; https://reviewboard.mozilla.org/r/60744/#review57612 Great!
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8765273 [details] Bug 1282222 - Clean up 'NotificationClient.java' ; https://reviewboard.mozilla.org/r/60740/#review57852
Attachment #8765273 -
Flags: review?(nchen) → review+
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8765274 [details] Bug 1282222 - Add a 'deleteIntent' parameter to the 'NotificationClient.add' method ; https://reviewboard.mozilla.org/r/60742/#review57850
Attachment #8765274 -
Flags: review?(nchen) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=409ff3b09ce8
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/4d1756f10acc Clean up 'NotificationClient.java' ;r=jchen https://hg.mozilla.org/integration/fx-team/rev/e68faf07dda2 Add a 'deleteIntent' parameter to the 'NotificationClient.add' method ;r=jchen https://hg.mozilla.org/integration/fx-team/rev/3ce3be36f582 Make the PersistentNotificationHandler handle 'persistent-notification-close' ;r=kitcambridge
Keywords: checkin-needed
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4d1756f10acc https://hg.mozilla.org/mozilla-central/rev/e68faf07dda2 https://hg.mozilla.org/mozilla-central/rev/3ce3be36f582
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•