Closed Bug 1282259 Opened 5 years ago Closed 5 years ago

Make ImageLib's DecodePool run IDecodingTasks instead of treating Decoders as tasks directly


(Core :: ImageLib, defect)

Not set



Tracking Status
firefox50 --- fixed


(Reporter: seth, Assigned: seth)


(Blocks 1 open bug)



(1 file, 2 obsolete files)

Right now DecodePool is a task pool in which the only possible tasks are Decoder objects. This is bad for two reasons:

(1) We probably eventually want to run other kinds of tasks in the same task pool.

(2) We need to stop treating the Decoders themselves as tasks in order to start allowing other objects to externally control the Decodes' state machines. In particular, this is necessary for streaming playback of animated GIFs and PNGs; if external objects can't control the decoders, we have no way of advancing playback in a controlled fashion to the frame we actually want to display. This means that we want to start moving control and coordination logic out of the Decoders.

To enable this, let's modify DecodePool to run IDecodingTasks instead of Decoders directly. Conveniently, this change will enable us to remove most or all of the non-thread-pool-related code from DecodePool.

I'm trying not to expand this bug's scope beyond what's necessary to accomplish this refactoring. In particular, for now DecoderFactory functions will continue to return Decoder objects. Soon we'll refactor them to return IDecodingTask objects, but changing that now would substantially increase the size of the patch in this bug.
Here's a try job for a version of the patch which is complete except for comments and other formatting issues:
Here's the patch. It should be pretty straightforward.

One note: this patch makes us do some extra allocation in that we now have an
IDecodingTask wrapping each Decoder, and they're allocated separately. A patch
in the very near future will make the IDecodingTasks store the Decoder objects
as members, so the extra allocation will go away.
Attachment #8765211 - Flags: review?(dholbert)
Blocks: 1282273
Blocks: 1282275
A small tweak: all pointers in the patch have been modified to use NotNull. I'm
trying to gradually introduce NotNull into ImageLib.
Attachment #8765300 - Flags: review?(dholbert)
Attachment #8765211 - Attachment is obsolete: true
Attachment #8765211 - Flags: review?(dholbert)
Comment on attachment 8765300 [details] [diff] [review]
Run IDecodingTasks instead of Decoders directly in image::DecodePool.

Review of attachment 8765300 [details] [diff] [review]:


::: image/Decoder.h
@@ +40,5 @@
>    /**
>     * Decodes, reading all data currently available in the SourceBuffer.
>     *
>     * If more data is needed, Decode() will schedule @aOnResume to be called when
> +   * more data is available.

In the documentation here, it's probably worth mentioning the fact that |aOnResume| must be non-null. (That's a new requirement that you're introducing in this patch.)

::: image/IDecodingTask.cpp
@@ +35,5 @@
> +
> +  // We're forced to notify asynchronously.
> +  NotNull<RefPtr<Decoder>> decoder = aDecoder;
> +  NS_DispatchToMainThread(NS_NewRunnableFunction([=]() -> void {
> +    decoder->GetImage()->NotifyProgress(decoder->TakeProgress(),

I'm not familiar enough with C++ lambdas to be confident that this code sufficiently refcounts |decoder| such that it's alive inside of the async runnable here.  (And as I type this, I'm currently on a plane, so I can't do further research at the moment. :) )

I trust your familiarity with newish C++ features, so for now I'll take it for granted that you've investigated this sufficiently to be 100% confident that the refcounting is kosher here. If that's not the case, please say so. :)  (Same goes for the FinalizeDecoder lambda a bit further down.)

@@ +77,5 @@
> +
> +DecodingTask::DecodingTask(NotNull<Decoder*> aDecoder)
> +  : mDecoder(aDecoder)
> +{
> +  MOZ_ASSERT(!mDecoder->IsMetadataDecode());

This assert is a bit enigmatic, without a bit more context.

Consider adding an one-liner message here to make the assertion's point clearer; e.g. "Metadata decodes should use MetadataDecodingTask, not DecodingTask"

@@ +113,5 @@
> +
> +MetadataDecodingTask::MetadataDecodingTask(NotNull<Decoder*> aDecoder)
> +  : mDecoder(aDecoder)
> +{
> +  MOZ_ASSERT(mDecoder->IsMetadataDecode());

...and maybe worth adding a message here as well, for symmetry with the suggested message above?  e.g. "Only metadata decodes should use  MetadataDecodingTask"

(admittedly, this assert is a bit more self-evident than the other one, based on this class's name. But seems worth documenting for symmetry/completeness.)

@@ +139,5 @@
> +///////////////////////////////////////////////////////////////////////////////
> +
> +AnonymousDecodingTask::AnonymousDecodingTask(NotNull<Decoder*> aDecoder)
> +  : mDecoder(aDecoder)
> +{ }

Nit on "{ }" -- I think Gecko coding style requires that the curly braces be on their own lines here (in a .cpp file), like so:

::: image/IDecodingTask.h
@@ +20,5 @@
> +namespace image {
> +
> +class Decoder;
> +
> +/// A priority hint DecodePool can use when scheduling an IDecodingTask.

Nit: s/hint/hint that/

(I stumbled over this the first time I read it; it initially sounds like "A priority hint DecodePool" might be a noun phrase of its own, until you get to the latter part of the sentence.  If you add "that", the correct reading is more self-evident.)

@@ +39,5 @@
> +
> +  /// @return true if, given the option, this task prefers to run synchronously.
> +  virtual bool ShouldPreferSyncRun() const = 0;
> +
> +  /// @return a priority hint DecodePool can use when scheduling this task.

As above: s/hint/hint that/  (to make this visually parse a bit more clearly).

::: image/ImageOps.cpp
@@ +127,5 @@
>    }
>    // Run the decoder synchronously.
> +  RefPtr<IDecodingTask> task = new AnonymousDecodingTask(WrapNotNull(decoder));
> +  task->Run();

Please add an #include for IDecodingTask.h to this file, to legitimize the usages of these "Task" types here. (Otherwise, this fails to compile, if you switch this file from being unified to non-unified -- and that means this is a unified-bustage timebomb.)
Attachment #8765300 - Flags: review?(dholbert) → review+
Thanks for the thorough review! Here's an updated version of the patch.
Attachment #8765300 - Attachment is obsolete: true
Blocks: 1283286
Pushed by
Run IDecodingTasks instead of Decoders directly in image::DecodePool. r=dholbert
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Depends on: 1283462
See Also: → 1261603
See Also: → 1294932
Blocks: 1306223
No longer blocks: 1306223
You need to log in before you can comment on or make changes to this bug.