Closed
Bug 1282277
Opened 8 years ago
Closed 8 years ago
'path:string' search finds nothing
Categories
(Webtools Graveyard :: DXR, defect)
Webtools Graveyard
DXR
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: aryx, Unassigned)
Details
(Keywords: regression)
At the moment, https://dxr.mozilla.org/mozilla-central/search?q=path%3Ainspector+animation&redirect=false finds nothing ("0 results from the mozilla-central tree") but should e.g. find https://dxr.mozilla.org/mozilla-central/source/devtools/client/animationinspector/animation-controller.js#26 All queries with path:string seem to return nothing.
Comment 1•8 years ago
|
||
Thanks for reporting, I think the regression occurred in https://github.com/mozilla/dxr/commit/36a1da185082c32db9c6183ae3913ed867d12763 which forced path globs to anchor to start and end of string. Evidence is that using a full path works, https://dxr.mozilla.org/mozilla-central/search?q=path%3Adevtools%2Fclient%2Fanimationinspector%2Fanimation-controller.js+animation&redirect=false.
Comment 2•8 years ago
|
||
For now (should be pretty short-lived) you can apply the work-around of wrapping the path query in *, e.g. path:*inspector* animation: https://dxr.mozilla.org/mozilla-central/search?q=path%3A*inspector*+animation&redirect=false
Comment 3•8 years ago
|
||
What's the status on this? It broke links that then misled contributors about what they needed to do, so I'm more than a little keen that we fix this ASAP. Also, does DXR have tests and/or continuous integration running somewhere? Feels like this kind of core functionality really shouldn't be breaking when pushing changes, so maybe tests should be added for this?
Comment 4•8 years ago
|
||
One way to address this quickly is to back the regression out, I guess?
Comment 5•8 years ago
|
||
Reverted in https://github.com/mozilla/dxr/commit/3144b0ca3022f6adf6f01e2e88d11b3fd86c6fae. We'll come at it a different way, without breaking backward-compat. One thought is introducing regex support for all or many operators, like ~path:^someRegex$ or ~function:create.*Member. Feelings?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 6•8 years ago
|
||
Assuming all goes well, that should be deployed in 15 minutes or so.
Updated•3 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•