1282345 - If a line number is given in the URL, Log viewer should go there instead of jumping to the first issue

Status: RESOLVED DUPLICATE of bug 1315808

(Tree Management :: Treeherder, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

STR:
1. Navigate to https://treeherder.mozilla.org/logviewer.html#?job_id=22651204&repo=try#L3842

Expected:
Log Viewer goes to line 3842.

Actual:
Log Viewer goes to line 521 (which is the location of the first issue), and even rewrites the URL with that line number!


Interestingly, with Log Viewer now open, if I replace '521' with '3842' in the URL and press Enter, the viewer correctly moves to line 3842 and stays there.

My (uninformed) guess is that when first opening, the Javascript code "helpfully" jumps to the first issue. It shouldn't do that when there's an explicit line number in the URL.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://github.com/mozilla/treeherder/commit/337e89145ece97068afec6de7d5052ddcaf3d445#diff-4f14c25b423d5c12f4983b7229fedeb1 conflicting with the earlier https://github.com/mozilla/treeherder/commit/fb70245edd22ca7c340dcb3d4860b99df8cb0ec6 or https://github.com/mozilla/treeherder/commit/4b1c450b95a23fb0bb47d42a5a5716a19d05acaa I guess...

Comment 2

[Ed Morley [:emorley]]

This reproduces even after bug 1315808.

Comment 3

[Hassan Ali (:hassan)]

I can't seem to reproduce this issue with the new Logviewer

Navigating to https://treeherder.mozilla.org/logviewer.html#?job_id=68103294&repo=mozilla-inbound&lineNumber=5 for example takes me to line 5, not 1981 (first issue).

Comment 4

[Ed Morley [:emorley]]

Huh so it does. I must have messed up the STR in comment 2 :-)