Closed
Bug 1282347
Opened 8 years ago
Closed 8 years ago
Use gfx::IntSize in CompositorBridgeParent ctor
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
Details
Attachments
(1 file)
10.44 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Tiny cleanup since this thing has about 45 parameters.
Attachment #8765326 -
Flags: review?(bugmail.mozilla)
Comment 2•8 years ago
|
||
Comment on attachment 8765326 [details] [diff] [review] patch Review of attachment 8765326 [details] [diff] [review]: ----------------------------------------------------------------- I'd prefer if we used a strongly-typed class like ScreenIntSize but consider that mEGLSurfaceSize is still a gfx::IntSize this is fine for now, we can do additional strong-typing at some later date.
Attachment #8765326 -
Flags: review?(bugmail.mozilla) → review+
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a8b01fe40d2f Use IntSize in CompositorBridgeParent's constructor. (bug 1282347, r=kats)
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a8b01fe40d2f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•