Closed Bug 1282354 Opened 3 years ago Closed 3 years ago

Insert SurfaceCache placeholders in the DecoderFactory

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file, 1 obsolete file)

So we're gradually moving to a model where the things that the SurfaceCache stores are smarter, and we'll be moving complexity out of other areas of the code. A small step in that direction is to start inserting SurfaceCache placeholders in the DecoderFactory instead of in RasterImage. The reason this is a good idea is that ISurfaceProviders are going to eliminate the need for placeholders pretty soon, and DecoderFactory is the place where they'll need to be configured, so this way the patch that does that can focus more on the actually meaningful changes and less on trivial refactoring like this.
Here's the patch.
Attachment #8765330 - Flags: review?(dholbert)
Comment on attachment 8765330 [details] [diff] [review]
Insert SurfaceCache placeholders in the DecoderFactory.

Review of attachment 8765330 [details] [diff] [review]:
-----------------------------------------------------------------

Commit message nit:
> Bug 1282354 - Insert SurfaceCache placeholders in the DecoderFactory. r=dholbert

This sounds like it's adding new code (but really it's just refactoring/moving code). Consider rewriting to make it clearer that this is a refactor/move. e.g. maybe something like:
 "Move code for SurfaceCache placeholder insertion into the DecoderFactory"

r=me
Attachment #8765330 - Flags: review?(dholbert) → review+
Thanks for the review! I've updated the commit message.
Attachment #8765330 - Attachment is obsolete: true
Pushed by mfowler@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fe160cfbce2
Move code for SurfaceCache placeholder insertion from RasterImage to DecoderFactory. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/1fe160cfbce2
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.