Closed Bug 1282361 Opened 8 years ago Closed 8 years ago

[TV] [Browser] Spatial navigation search bar back key not working

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.6+, b2g-v2.6 fixed)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g 2.6+
Tracking Flags:
Tracking Status
b2g-v2.6 --- fixed

People

(Reporter: twen, Assigned: danhuang)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

[gaia] danhuang1202:2.6_1282361 > mozilla-b2g:v2.6
46 bytes, text/x-github-pull-request
lchang
: review+
jocheng
: approval-gaia-v2.6+
Details | Review
When in search bar menu, pressing back key is suppose to exit search menu. [Test Steps] 1. open browser 2. start type keyword 3. press back 4. press back [Expected result] Exit search, and return to browser See UX spec: 3-9 [Actual result] No effect Latest UX spec: https://drive.google.com/drive/folders/0B5RN80W56Ga9V3k3VEpsNXd6M00
Whiteboard: [ft:conndevices]
2.6 feature
blocking-b2g: --- → 2.6?
status-b2g-v2.6: --- → affected
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
Please help review this patch. This patch will close the search result view when clicking the back key on the search input. Thanks.
Flags: needinfo?(lchang)
Attachment #8765720 - Flags: review?(lchang)
Flags: needinfo?(lchang)
Comment on attachment 8765720 [details] [review] [gaia] danhuang1202:2.6_1282361 > mozilla-b2g:v2.6 Looks good. Thanks.
Attachment #8765720 - Flags: review?(lchang) → review+
Comment on attachment 8765720 [details] [review] [gaia] danhuang1202:2.6_1282361 > mozilla-b2g:v2.6 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): TV 2.6 [User impact] if declined: Not align to UX spex [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): None [String changes made]: None
Attachment #8765720 - Flags: approval-gaia-v2.6?
Comment on attachment 8765720 [details] [review] [gaia] danhuang1202:2.6_1282361 > mozilla-b2g:v2.6 Approve for TV 2.6
Attachment #8765720 - Flags: approval-gaia-v2.6? → approval-gaia-v2.6+
blocking-b2g: 2.6? → 2.6+
Merge in v2.6: https://github.com/mozilla-b2g/gaia/commit/4d8366c683d760e5641ab348d43cb1d339ff3c41
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-b2g-v2.6: affected → fixed
Resolution: --- → FIXED
Verified fixed on v2.6 branch mulet.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: