Remove Android-N tab-count flickering workaround (now fixed in latest Android N preview)

RESOLVED FIXED in Firefox 50

Status

()

Firefox for Android
Theme and Visual Design
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ahunt, Assigned: ahunt)

Tracking

Trunk
Firefox 50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Previous Android N previews had a bug causing flickering in the tab button (count / curve) on phones. This has been fixed in the latest N preview (build NPD56N). We landed a workaround in Bug 1264783, we should remove it again to avoid shipping unnecessary (and possibly slower) code.
(Assignee)

Updated

2 years ago
Depends on: 1264783
(Assignee)

Comment 1

2 years ago
Created attachment 8765365 [details]
Bug 1282372 - Remove tab count transparency/flickering workaround

This issue has been fixed in the latest Android N preview, we should
remove the workaround to simplify the code.

Review commit: https://reviewboard.mozilla.org/r/60786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60786/
Attachment #8765365 - Flags: review?(s.kaspari)
(Assignee)

Updated

2 years ago
Assignee: nobody → ahunt
Status: NEW → ASSIGNED
Summary: Remove Android-N tab-count flickering workaround (now fixed in Android N) → Remove Android-N tab-count flickering workaround (now fixed in latest Android N preview)
Comment on attachment 8765365 [details]
Bug 1282372 - Remove tab count transparency/flickering workaround

https://reviewboard.mozilla.org/r/60786/#review57608

yay!
Attachment #8765365 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/d0660ed2320b5de0b116330b58c80cd3d3044879
Bug 1282372 - Remove tab count transparency/flickering workaround r=sebastian

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d0660ed2320b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in before you can comment on or make changes to this bug.