Closed Bug 1282398 Opened 3 years ago Closed 3 years ago

Fix all flake8 errors in testing/talos/talos

Categories

(Testing :: Talos, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: malayaleecoder, Assigned: malayaleecoder, Mentored)

References

Details

(Whiteboard: [talos_wishlist])

Attachments

(3 files, 1 obsolete file)

Attached file flake8_errors.txt
Running the flake8 in testing/talos/talos, yield many instances where it fails.
This bug aims to fix all of those errors to make it perfect.

PFA the list of conflicts.
Please Note: This occurs for python 3
Attached patch Bug1282398_v1.diff (obsolete) — Splinter Review
I have fixed almost all the errors, except for the ones given in flake8_errors_after_patch.txt 

Not sure what to do for the rest of the conflicts. :jmaher, do suggest some alternatives.
Assignee: nobody → malayaleecoder
Status: NEW → ASSIGNED
Attachment #8765974 - Flags: feedback?(jmaher)
All of them are "F821 undefined name" errors.
Comment on attachment 8765974 [details] [diff] [review]
Bug1282398_v1.diff

Review of attachment 8765974 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great, I am not sure if the except changes work in python 2.7, maybe it is 2.5 that won't work- I would like to see a try run to ensure that talos runs fine and passes the flake8 for 2.7 :)
Attachment #8765974 - Flags: feedback?(jmaher) → feedback+
I see file() is an api call, possibly we can use with open() instead or replace these api calls with something.  Right now the list is smaller, I suspect a few of these issues can be easily fixed, the others might have to wait.
Here is the try for this patch,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d80ab53efe0
Attachment #8765974 - Attachment is obsolete: true
Attachment #8766180 - Flags: review?(jmaher)
Comment on attachment 8766180 [details] [diff] [review]
Bug1282398_v2.diff

Review of attachment 8766180 [details] [diff] [review]:
-----------------------------------------------------------------

very nice!
Attachment #8766180 - Flags: review?(jmaher) → review+
Whiteboard: [talos_wishlist]
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/408b1ffc45c8
Fix all flake8 errors in testing/talos/talos. r=jmaher
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/408b1ffc45c8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.