1282398 - Fix all flake8 errors in testing/talos/talos

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Vishnu (:malayaleecoder)]

Attachment: flake8_errors.txt

Running the flake8 in testing/talos/talos, yield many instances where it fails.
This bug aims to fix all of those errors to make it perfect.

PFA the list of conflicts.

Comment 1

[Vishnu (:malayaleecoder)]

Please Note: This occurs for python 3

Comment 2

[Vishnu (:malayaleecoder)]

Attachment: Bug1282398_v1.diff

I have fixed almost all the errors, except for the ones given in flake8_errors_after_patch.txt 

Not sure what to do for the rest of the conflicts. :jmaher, do suggest some alternatives.

Comment 3

[Vishnu (:malayaleecoder)]

Attachment: flake8_errors_after_patch.txt

All of them are "F821 undefined name" errors.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8765974 [details] [diff] [review]
Bug1282398_v1.diff

Review of attachment 8765974 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great, I am not sure if the except changes work in python 2.7, maybe it is 2.5 that won't work- I would like to see a try run to ensure that talos runs fine and passes the flake8 for 2.7 :)

Comment 5

[Vishnu (:malayaleecoder)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f7a3ee44c91

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

I see file() is an api call, possibly we can use with open() instead or replace these api calls with something.  Right now the list is smaller, I suspect a few of these issues can be easily fixed, the others might have to wait.

Comment 7

[Vishnu (:malayaleecoder)]

Attachment: Bug1282398_v2.diff

Here is the try for this patch,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d80ab53efe0

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8766180 [details] [diff] [review]
Bug1282398_v2.diff

Review of attachment 8766180 [details] [diff] [review]:
-----------------------------------------------------------------

very nice!

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

this is great to land

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/408b1ffc45c8
Fix all flake8 errors in testing/talos/talos. r=jmaher

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/408b1ffc45c8