Closed Bug 1282424 Opened 4 years ago Closed 4 years ago

[Static Analysis][Uninitialized scalar field] In constructor SpecularLightingSoftware

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1362708)

Attachments

(1 file)

The Static Analysis tool Coverity detected that variable |mSpecularConstantInt| is not initialised in the default constructor like the rest of the members are. As we try to push this static analysis tool based on clang - https://bugzilla.mozilla.org/show_bug.cgi?id=525063
we must prepare our code and fix this sort of issues.
Attachment #8765445 - Flags: review?(jmuizelaar) → review?(mstange)
Attachment #8765445 - Flags: review?(mstange) → review+
Comment on attachment 8765445 [details]
Bug 1282424 - initialize member variable |mSpecularConstantInt| in SpecularLightingSoftware.

https://reviewboard.mozilla.org/r/60814/#review57880

thanks
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80a1f6aa0e72
initialize member variable |mSpecularConstantInt| in SpecularLightingSoftware. r=mstange
https://hg.mozilla.org/mozilla-central/rev/80a1f6aa0e72
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.