Reps: handle userDisplayName property on Function grips

RESOLVED FIXED in Firefox 50

Status

DevTools
Shared Components
P1
normal
RESOLVED FIXED
2 years ago
6 days ago

People

(Reporter: linclark, Assigned: gasolin@mozilla.com)

Tracking

Trunk
Firefox 50
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [devtools-html])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
In our actors, we make a distinction between the function's default displayName and any user-set display name, which is userDisplayName. The grip should prioritize the userDisplayName.
(Reporter)

Updated

2 years ago
Whiteboard: [devtools-html] [triage]

Updated

2 years ago
Blocks: 1263741

Updated

2 years ago
Flags: qe-verify-
Priority: -- → P3
Whiteboard: [devtools-html] [triage] → [reserve-html]

Updated

2 years ago
Priority: P3 → P2
Whiteboard: [reserve-html] → [devtools-html]
(Assignee)

Comment 1

2 years ago
Created attachment 8770419 [details]
Bug 1282427 - Reps: handle userDisplayName property on Function grips;

Review commit: https://reviewboard.mozilla.org/r/63888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63888/
(Assignee)

Comment 2

2 years ago
Comment on attachment 8770419 [details]
Bug 1282427 - Reps: handle userDisplayName property on Function grips;

I've no idea how to test the userDisplayName, but according to server/actor/object
https://dxr.mozilla.org/mozilla-central/source/devtools/server/actors/object.js#1134

userDisplayName seems present as an attribute of grip object if user specified the display name. I made a quick patch and like to see if its in a right direction.
Attachment #8770419 - Flags: feedback?(lclark)

Updated

2 years ago
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Iteration: --- → 50.3 - Jul 18
Priority: P2 → P1
(Reporter)

Comment 3

2 years ago
Comment on attachment 8770419 [details]
Bug 1282427 - Reps: handle userDisplayName property on Function grips;

https://reviewboard.mozilla.org/r/63888/#review60988

This looks exactly right to me. If it passes tests, then I think this one is good to go. Thanks!
Attachment #8770419 - Flags: review+
(Reporter)

Updated

2 years ago
Attachment #8770419 - Flags: feedback?(lclark)
(Assignee)

Comment 4

2 years ago
test passed, add checkin-needed flag

thanks!
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/604f5e565210
Reps: handle userDisplayName property on Function grips. r=linclark
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/604f5e565210
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50

Updated

6 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.