|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
In our actors, we make a distinction between the function's default displayName and any user-set display name, which is userDisplayName. The grip should prioritize the userDisplayName.
Priority: -- → P3
Whiteboard: [devtools-html] [triage] → [reserve-html]
Priority: P3 → P2
Whiteboard: [reserve-html] → [devtools-html]
Created attachment 8770419 [details] Bug 1282427 - Reps: handle userDisplayName property on Function grips; Review commit: https://reviewboard.mozilla.org/r/63888/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63888/
Comment on attachment 8770419 [details] Bug 1282427 - Reps: handle userDisplayName property on Function grips; I've no idea how to test the userDisplayName, but according to server/actor/object https://dxr.mozilla.org/mozilla-central/source/devtools/server/actors/object.js#1134 userDisplayName seems present as an attribute of grip object if user specified the display name. I made a quick patch and like to see if its in a right direction.
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Iteration: --- → 50.3 - Jul 18
Priority: P2 → P1
Comment on attachment 8770419 [details] Bug 1282427 - Reps: handle userDisplayName property on Function grips; https://reviewboard.mozilla.org/r/63888/#review60988 This looks exactly right to me. If it passes tests, then I think this one is good to go. Thanks!
Attachment #8770419 - Flags: review+
test passed, add checkin-needed flag thanks!
Pushed by email@example.com: https://hg.mozilla.org/integration/fx-team/rev/604f5e565210 Reps: handle userDisplayName property on Function grips. r=linclark
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in before you can comment on or make changes to this bug.