Closed Bug 1282427 Opened 4 years ago Closed 4 years ago

Reps: handle userDisplayName property on Function grips

Categories

(DevTools :: Shared Components, defect, P1)

defect

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.3 - Jul 18
Tracking Status
firefox50 --- fixed

People

(Reporter: linclark, Assigned: gasolin)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

In our actors, we make a distinction between the function's default displayName and any user-set display name, which is userDisplayName. The grip should prioritize the userDisplayName.
Whiteboard: [devtools-html] [triage]
Flags: qe-verify-
Priority: -- → P3
Whiteboard: [devtools-html] [triage] → [reserve-html]
Priority: P3 → P2
Whiteboard: [reserve-html] → [devtools-html]
Comment on attachment 8770419 [details]
Bug 1282427 - Reps: handle userDisplayName property on Function grips;

I've no idea how to test the userDisplayName, but according to server/actor/object
https://dxr.mozilla.org/mozilla-central/source/devtools/server/actors/object.js#1134

userDisplayName seems present as an attribute of grip object if user specified the display name. I made a quick patch and like to see if its in a right direction.
Attachment #8770419 - Flags: feedback?(lclark)
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Iteration: --- → 50.3 - Jul 18
Priority: P2 → P1
Comment on attachment 8770419 [details]
Bug 1282427 - Reps: handle userDisplayName property on Function grips;

https://reviewboard.mozilla.org/r/63888/#review60988

This looks exactly right to me. If it passes tests, then I think this one is good to go. Thanks!
Attachment #8770419 - Flags: review+
Attachment #8770419 - Flags: feedback?(lclark)
test passed, add checkin-needed flag

thanks!
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/604f5e565210
Reps: handle userDisplayName property on Function grips. r=linclark
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/604f5e565210
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.