1282427 - Reps: handle userDisplayName property on Function grips

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect, P1)

Description

[Lin Clark [:linclark]]

In our actors, we make a distinction between the function's default displayName and any user-set display name, which is userDisplayName. The grip should prioritize the userDisplayName.

Comment 1

[[e-mail]]

Attachment: Bug 1282427 - Reps: handle userDisplayName property on Function grips;

Review commit: https://reviewboard.mozilla.org/r/63888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63888/

Comment 2

[[e-mail]]

Comment on attachment 8770419 [details]
Bug 1282427 - Reps: handle userDisplayName property on Function grips;

I've no idea how to test the userDisplayName, but according to server/actor/object
https://dxr.mozilla.org/mozilla-central/source/devtools/server/actors/object.js#1134

userDisplayName seems present as an attribute of grip object if user specified the display name. I made a quick patch and like to see if its in a right direction.

Comment 3

[Lin Clark [:linclark]]

Comment on attachment 8770419 [details]
Bug 1282427 - Reps: handle userDisplayName property on Function grips;

https://reviewboard.mozilla.org/r/63888/#review60988

This looks exactly right to me. If it passes tests, then I think this one is good to go. Thanks!

Comment 4

[[e-mail]]

test passed, add checkin-needed flag

thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/604f5e565210
Reps: handle userDisplayName property on Function grips. r=linclark

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/604f5e565210