Closed Bug 1282463 Opened 3 years ago Closed 3 years ago

Reps: ensure that grip arrays work even when a provider is not provided

Categories

(DevTools :: Shared Components, defect, P1)

defect

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.2 - Jul 4
Tracking Status
firefox50 --- fixed

People

(Reporter: linclark, Assigned: Honza)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

Currently, if you pass in [1, "foo", {}] to the grip array, the tiny mode will output `[3]` and the other modes will output `[]`.
Whiteboard: [devtools-html] [triage]
Blocks: 1282465
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [devtools-html]
Attached patch bug1282463.patchSplinter Review
Patch attached.

Lin, let me know if I should assign somebody else for the review.

Honza
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Attachment #8767128 - Flags: review?(lclark)
Iteration: --- → 50.2 - Jul 4
Priority: P2 → P1
Comment on attachment 8767128 [details] [diff] [review]
bug1282463.patch

Review of attachment 8767128 [details] [diff] [review]:
-----------------------------------------------------------------

Manually tested this and it works for me. 

We talked about the additional review in the meeting. Unless I'm missing something, for this issue I don't think that we need to worry about testing all possible grip types. We may want to ask someone to review the rep system generally to make sure that we've covered all grip types though.
Attachment #8767128 - Flags: review?(lclark) → review+
OK, great. I was actually retesting this again with bunch of different data and all works for me so, I totally agree with you.

Thanks Lin!
Honza
Flags: needinfo?(poirot.alex)
Keywords: checkin-needed
Ah, removing unwanted NI, sorry.
Honza
Flags: needinfo?(poirot.alex)
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/668d29620e0b
Reps: ensure that grip arrays work even when a provider is not provided; r=linclark
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/668d29620e0b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.