Closed
Bug 1282463
Opened 8 years ago
Closed 8 years ago
Reps: ensure that grip arrays work even when a provider is not provided
Categories
(DevTools :: Shared Components, defect, P1)
DevTools
Shared Components
Tracking
(firefox50 fixed)
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: linclark, Assigned: Honza)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file)
1.31 KB,
patch
|
linclark
:
review+
|
Details | Diff | Splinter Review |
Currently, if you pass in [1, "foo", {}] to the grip array, the tiny mode will output `[3]` and the other modes will output `[]`.
Reporter | ||
Updated•8 years ago
|
Whiteboard: [devtools-html] [triage]
Updated•8 years ago
|
Blocks: devtools-html-2
Updated•8 years ago
|
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [devtools-html]
Assignee | ||
Comment 1•8 years ago
|
||
Patch attached. Lin, let me know if I should assign somebody else for the review. Honza
Updated•8 years ago
|
Iteration: --- → 50.2 - Jul 4
Priority: P2 → P1
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8767128 [details] [diff] [review] bug1282463.patch Review of attachment 8767128 [details] [diff] [review]: ----------------------------------------------------------------- Manually tested this and it works for me. We talked about the additional review in the meeting. Unless I'm missing something, for this issue I don't think that we need to worry about testing all possible grip types. We may want to ask someone to review the rep system generally to make sure that we've covered all grip types though.
Attachment #8767128 -
Flags: review?(lclark) → review+
Assignee | ||
Comment 3•8 years ago
|
||
OK, great. I was actually retesting this again with bunch of different data and all works for me so, I totally agree with you. Thanks Lin! Honza
Flags: needinfo?(poirot.alex)
Keywords: checkin-needed
Assignee | ||
Comment 4•8 years ago
|
||
Ah, removing unwanted NI, sorry. Honza
Flags: needinfo?(poirot.alex)
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/668d29620e0b Reps: ensure that grip arrays work even when a provider is not provided; r=linclark
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/668d29620e0b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•