Silence push error logging on Aurora and Beta

RESOLVED FIXED

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: lina, Assigned: lina)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8765493 [details] [diff] [review]
squelchLogging.patch

Bug 1258595 flipped "dom.push.loglevel" to "error". Unfortunately, this caused spurious logging (bug 1265914), where the "error" is both expected and harmless. The two-part fix is in bug 1265914 and bug 1265915, but that's a large chunk of code to uplift through to Beta.

Instead, let's just disable logging and let those two patches ride the trains.
Attachment #8765493 - Flags: approval-mozilla-beta?
Attachment #8765493 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 1

2 years ago
Approval Request Comment
[Feature/regressing bug #]: Bug 1265914.
[User impact if declined]: Confusing push error logs in the browser console.
[Describe test coverage new/current, TreeHerder]: None; this is a logging level change.
[Risks and why]: No risk. Small pref change that reverts push logging to silent.
[String/UUID change made/needed]: None.
status-firefox48: --- → affected
status-firefox49: --- → affected
Comment on attachment 8765493 [details] [diff] [review]
squelchLogging.patch

Thanks. Remove the confusing warning, taking it.
Should be in 48 beta 4 or 5
Attachment #8765493 - Flags: approval-mozilla-beta?
Attachment #8765493 - Flags: approval-mozilla-beta+
Attachment #8765493 - Flags: approval-mozilla-aurora?
Attachment #8765493 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/27d8dcd55b2e
https://hg.mozilla.org/releases/mozilla-beta/rev/b0c78c7d137a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
status-firefox49: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.