Closed Bug 1282476 Opened 7 years ago Closed 7 years ago

Silence push error logging on Aurora and Beta

Categories

(Core :: DOM: Push Notifications, defect)

Product:
Core
Component:
DOM: Push Notifications
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: lina, Assigned: lina)

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

squelchLogging.patch
930 bytes, patch
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Bug 1258595 flipped "dom.push.loglevel" to "error". Unfortunately, this caused spurious logging (bug 1265914), where the "error" is both expected and harmless. The two-part fix is in bug 1265914 and bug 1265915, but that's a large chunk of code to uplift through to Beta.

Instead, let's just disable logging and let those two patches ride the trains.
Attachment #8765493 - Flags: approval-mozilla-beta?
Attachment #8765493 - Flags: approval-mozilla-aurora?
Approval Request Comment
[Feature/regressing bug #]: Bug 1265914.
[User impact if declined]: Confusing push error logs in the browser console.
[Describe test coverage new/current, TreeHerder]: None; this is a logging level change.
[Risks and why]: No risk. Small pref change that reverts push logging to silent.
[String/UUID change made/needed]: None.
Comment on attachment 8765493 [details] [diff] [review]
squelchLogging.patch

Thanks. Remove the confusing warning, taking it.
Should be in 48 beta 4 or 5
Attachment #8765493 - Flags: approval-mozilla-beta?
Attachment #8765493 - Flags: approval-mozilla-beta+
Attachment #8765493 - Flags: approval-mozilla-aurora?
Attachment #8765493 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.