1282506 - The patches for bug 1025965 broke firefox ui tests with test_safe_browsing_initial_download.py TestSafeBrowsingInitialDownload.test_safe_browsing_initial_download

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/#/jobs?repo=fx-team&fromchange=8f48d2f1fa58dbb978abc28051f3550724800b2f&group_state=expanded&filter-searchStr=en-

https://treeherder.mozilla.org/logviewer.html#?job_id=10119504&repo=fx-team


These are tier-2, so no backout, but these need to get fixed.

Comment 1

[Intermittent Failures Robot]

48 automation job failures were associated with this bug yesterday.

Repository breakdown:
* fx-team: 48

Platform breakdown:
* linux64: 48

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1282506&startday=2016-06-27&endday=2016-06-27&tree=all

Comment 2

[Thomas Nguyen (:tnguyen)]

Hmm, there's a new test using old preference browser.safebrowsing.enabled was pushed last friday.
Should be change to use browser.safebrowsing.phishing.enabled. Sorry that I did not rebase that commit.

Comment 3

[Thomas Nguyen (:tnguyen)]

Attachment: Fix broken test

Comment 4

[Thomas Nguyen (:tnguyen)]

Try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ec4d63fe745

Comment 5

[Intermittent Failures Robot]

58 automation job failures were associated with this bug yesterday.

Repository breakdown:
* fx-team: 58

Platform breakdown:
* linux64: 58

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1282506&startday=2016-06-28&endday=2016-06-28&tree=all

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8765714 [details] [diff] [review]
Fix broken test

Review of attachment 8765714 [details] [diff] [review]:
-----------------------------------------------------------------

As the peer of firefox-ui-tests I will steal this review from Francois now so that we can get this permanent failure fixed. Thanks Thomas for following up on it. Before landing make sure that you update the reviewer in your commit message. Thanks.

Comment 7

[Thomas Nguyen (:tnguyen)]

Attachment: Fix broken test

Thanks for your review

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/51f0ef5a8b67
Fix broken firefox ui tests with test_safe_browsing_initial_download.py. r=whimboo

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/51f0ef5a8b67

Comment 10

[Intermittent Failures Robot]

190 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 73
* mozilla-inbound: 71
* fx-team: 34
* mozilla-central: 12

Platform breakdown:
* linux64: 179
* windows8-64: 2
* windows7-64: 2
* windowsxp: 1
* windows8-32: 1
* windows7-32: 1
* osx-10-9: 1
* osx-10-11: 1
* osx-10-10: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1282506&startday=2016-06-29&endday=2016-06-29&tree=all

Comment 11

[Intermittent Failures Robot]

507 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 252
* fx-team: 152
* autoland: 85
* mozilla-central: 18

Platform breakdown:
* linux64: 496
* windows8-64: 2
* windows7-64: 2
* windowsxp: 1
* windows8-32: 1
* windows7-32: 1
* osx-10-9: 1
* osx-10-11: 1
* osx-10-10: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1282506&startday=2016-06-27&endday=2016-07-03&tree=all