Closed Bug 1282527 Opened 8 years ago Closed 8 years ago

Remove remaining PR_ASSERTs outside of NSPR/NSS

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: khuey, Assigned: khuey)

Details

Attachments

(1 file)

Patch
8.61 KB, patch
dbaron
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
There are some PR_ASSERT(0)s left which I've ignored for the moment.
Attachment #8765538 - Flags: review?(dbaron)
Comment on attachment 8765538 [details] [diff] [review]
Patch

Could use a better commit message.

And also perhaps fix the space between MOZ_ASSERT and ( in nsZipArchive.cpp (twice).
Attachment #8765538 - Flags: review?(dbaron) → review+
Pushed by khuey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ceb14aa24e8
Remove remaining PR_ASSERTs outside of NSPR/NSS. r=dbaron
https://hg.mozilla.org/mozilla-central/rev/5ceb14aa24e8
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: