1282529 - Allow filtering of submitted_from_infobar crashes while searching

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[[:philipp]]

bug 1269998 basically doubled the amount rate of crashes that get submitted - those get tagged with submitted_from_infobar. it would be useful if those crashes could be filtered out from search results (for example to compare the situation with older builds without that new submission mechanism).

currently it's possible to set "submitted from infobar" is true/is false in a socorro search, but the latter option always returns 0 results: https://crash-stats.mozilla.com/search/?product=Firefox&submitted_from_infobar=!__true__

Comment 1

[Peter Bengtsson [:peterbe]]

I suspect what we need is to change the options from "true/false" to "true/exists/false" or something. I dare not guess how that's supposed to be done. 

Especially since this field doesn't exist on stage. https://crash-stats.allizom.org/admin/supersearch-field/?name=submitted_from_infobar

Comment 2

[Liz Henry (:lizzard)]

Note, we want this in order to bring the delayed submit crash change into beta 48 but still be able to filter out those crashes so we can compare stats between 48 and older versions.

Comment 3

[Jim Mathies [:jimm]]

This appears to be working through the search page - 

https://crash-stats.mozilla.com/search/?product=Firefox&submitted_from_infobar=__true__&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3384

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/a30908ee968ff605e96a0268205349fbdaa44f14
Fixes bug 1282529 - Include null values in results with falsy boolean filter. (#3384)

Comment 6

[Peter Bengtsson [:peterbe]]

Hmm... I tested it wrongly (in hindsight), then merged the PR and then tested it correctly. The code does NOT work. 
Trying to figure out why and what.

Comment 7

[Peter Bengtsson [:peterbe]]

It does not appear to work. I make this search: http://jmp.sh/ssEAAXD
And click on the first available crash ID, and look on the Metadata tab: https://jumpshare.com/v/PwoMUlJOJPT4WwP1cXG4
it's supposedly "true" on this but it got found even though I searched for "is false". 

Even more pressing, nothing comes back when searching for "is true": https://jumpshare.com/v/qrbFLhiVrnYrg3w4fPFY

Actively trying to understand what's going on.

Comment 8

[Peter Bengtsson [:peterbe]]

Not a final explanation but the problem is that the "SubmittedFromInfobar" is not a true boolean. 
See https://crash-stats.mozilla.com/report/index/d7814143-6925-4d86-ad69-05b1d2160711 for example. (Click Metadata tab). 

But when you load up the raw JSON: https://crash-stats.mozilla.com/api/RawCrash/?crash_id=d7814143-6925-4d86-ad69-05b1d2160711&format=meta you'll see that it's not a true boolean. It's a 4 character string. E.g. "true". 

I think the SuperSearch field is wrong. It needs be a regular string search. If the breakpad client sends it like this, there's not a lot we can do.


Looking at another example:
EMCheckCompatibility is also a boolean looking string. E.g. "true" or "false"
(note-to-self: http://socorro.dev/admin/supersearch-field/?name=em_check_compatibility)
Example: https://crash-stats.mozilla.com/rawdumps/d5e51824-0931-44bf-9b52-4637b2160711.json

On "em check compatibility" I can search for "is true" and "is false" and it finds crashes under both. So that works. 

I can't see how that's different from SubmittedFromInfobar.

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/55723bc2ddc5ec462b04af790fc4d6f6f82fc086
Revert "Fixes bug 1282529 - Include null values in results with falsy boolean filter."

https://github.com/mozilla/socorro/commit/ed8d960edd1da1d22b4683667d3f436c7faf180d
Merge pull request #3385 from mozilla/revert-3384-1282529-boolean-filter-supersearch

Revert "Fixes bug 1282529 - Include null values in results with falsy boolean filter."

Comment 10

[Peter Bengtsson [:peterbe]]

Why did you revert the PR? I don't think it was working before either.

Comment 11

[Peter Bengtsson [:peterbe]]

I changed the super search field on STAGE and **now it (sort of) works**.
https://crash-stats.allizom.org/search/?product=Firefox&submitted_from_infobar=%21__null__&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=version&_columns=submitted_from_infobar#crash-reports

Every raw crash is either "SubmittedFromInfobar=true" or it's non-existed. 

I changed the field so that it has the choices "exists" and "does not exist". This works for now because there are no crashes with "SubmittedFromInfobar=false".


Now I've also applied this on PROD. 

Compare: 
https://crash-stats.mozilla.com/search/?product=Firefox&submitted_from_infobar=%21__null__&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=version&_columns=submitted_from_infobar#crash-reports
https://crash-stats.mozilla.com/search/?product=Firefox&submitted_from_infobar=__null__&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=version&_columns=submitted_from_infobar#crash-reports

If you look at the sums of those two and make a third query *without* "submitted from infobar" then it does add up. 

Leaving this open till Adrian and I can figure out a better looking solution.

Comment 12

[[:philipp]]

thanks for fixing it so far :))

Comment 13

[Lonnen :lonnen]

We had to revert two changes on stage in order to rush an infrastructure change out the door. I did not properly follow up with relanding them after. Many apologies.

Comment 14

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/eea662404df8645e19f8cba772350ae52c0d1941
Revert "Revert "Fixes bug 1282529 - Include null values in results with falsy boolean filter.""

Comment 15

[Peter Bengtsson [:peterbe]]

Sorry. Our bugcloser is too eager to close bugs based on git commit messages.

Comment 16

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/062d3992e8d9de4a0c7f0a9a3ddea294a34e78b0
Fixes bug 1282529 - Removed field name from truthy Elasticsearch operator. (#3392)