Closed
Bug 1282537
Opened 8 years ago
Closed 8 years ago
Change the wording in the confirm box for "Enable multi-process Nightly"
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
FIXED
Firefox 50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: milan, Assigned: milan)
References
Details
Attachments
(1 file)
See bug 973014 for the long discussion on the wording, and bug 1169306 for some of the problems people run into. The "Nightly must restart to disable this feature." - OK/Cancel is confusing. While the full solution may be to be able to defer the change until restart, at least changing the wording on the buttons makes it clearer what will happen now - see bug 973014 for the UX discussion on the topic.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → milan
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/60862/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/60862/
Attachment #8765550 -
Flags: review?(jmathies)
Assignee | ||
Comment 2•8 years ago
|
||
By the way, the two buttons are "Restart Nightly now" (or whatever version we're running) and "Revert", with "Revert" being the default/highlighted one.
Assignee | ||
Updated•8 years ago
|
Comment 3•8 years ago
|
||
Comment on attachment 8765550 [details] Bug 1282537: Better wording for the E10S restart required confirm box. https://reviewboard.mozilla.org/r/60862/#review57954 I'd suggest changing "Revert" to "Cancel", at least on Windows. Also if you canmove the Cancel button to the right side of the dialog.
Attachment #8765550 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #3) > Comment on attachment 8765550 [details] > Bug 1282537: Better wording for the E10S restart required confirm box. > > https://reviewboard.mozilla.org/r/60862/#review57954 > > I'd suggest changing "Revert" to "Cancel", at least on Windows. Also if you > canmove the Cancel button to the right side of the dialog. I don't really care about the wording, except for bug 973014 comment 16 asking for »Revert« and »Restart $product now« and coming from UX, so you have to convince them first :) And, yes, the Revert(Cancel) button is already on the right side of the dialog, and is the default/highlighted option, so a quick Enter without reading doesn't restart the browser.
Assignee | ||
Comment 5•8 years ago
|
||
https://reviewboard.mozilla.org/r/60862/#review57954 Keeping the wording as is, because of the explicit UX direction (see bug 973014 comment 16), but I obviously don't have an emotional attachment to either wording. The Revert/Cancel button already on the far right.
Pushed by msreckovic@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b52d27f7628f Better wording for the E10S restart required confirm box. r=jimm
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b52d27f7628f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Assignee | ||
Comment 8•8 years ago
|
||
Made adjustments to this in bug 1285328.
You need to log in
before you can comment on or make changes to this bug.
Description
•