Closed Bug 1282554 Opened 4 years ago Closed 4 years ago

Provide helper function to check if channel can be openen using open2() and asyncOpen2()

Categories

(Core :: DOM: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

No description provided.
Assignee: nobody → ckerschb
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]
Blocks: 1279481
Hey Bobby, I created a helper function within NetUtil.cpp which allows to check whether we can/should open the channel using open2() or asyncOpen2() respectively. While doing so I also updated those bits that somehow incorrectly use GetEnforceSecurity() instead of GetSecurityMode(). GetEnforceSecurity() was rather meant for redirects.
Attachment #8765847 - Flags: review?(bobbyholley)
Comment on attachment 8765847 [details] [diff] [review]
bug_1282554_provide_helper_for_open2.patch

Review of attachment 8765847 [details] [diff] [review]:
-----------------------------------------------------------------

This is much better - thank you!
Attachment #8765847 - Flags: review?(bobbyholley) → review+
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/063d90be43fc
Provide helper function to check if channel can be openen using open2() and asyncOpen2() r=bholly
https://hg.mozilla.org/mozilla-central/rev/063d90be43fc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.