1282568 - Failing add-ons in mozapps tests

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Andy McKay]

There's two add-ons in mozapps tests that are failing tests, it looks like the tests relied on signing being turned off here:

https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/browser/browser_update.js#12

That's not going to work once the pref goes away.

I'll see if I can sign those two add-ons and remove that pref twiddling code.

Comment 1

[Andy McKay]

Attachment: out.patch

Sorry, I wasn't expecting to make any commits today and haven't got my ssh keys set up on this box so pushing to mozreview fails for me. I will remember to sync up those keys.

This is a really easy diff because its 2 lines and lots of binary.

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8765635 [details] [diff] [review]
out.patch

Looks good to me, I started a try run though:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5dc28497bf6

Comment 3

[Kim Moir [:kmoir] ET]

If the patch is okay, it will have to land on mozilla-beta as well as land on inbound etc to address the test failures that prevent us from enabling the preference to toggle installing unsigned addons.

Comment 4

[Andy McKay]

Attachment: second-pass.patch

Actually sign the correct add-ons this time.

Comment 5

[Andrew Swan [:aswan]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8fcca075fde4ffb11ad527786a740f0072ee6ab
bug 1282568 sign add-ons in browser_update tests r=aswan

Comment 6

[Kim Moir [:kmoir] ET]

If this fixes the issue, could you please upload to beta so we can enable the signed preference again? You can use a=test-only since test changes don't need relman approval

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a8fcca075fde

Comment 8

[Kim Moir [:kmoir] ET]

reopening, this change need to land on m-b for bug 1186522

Comment 9

[Andrew Swan [:aswan]]

Landed in beta, should this also go into aurora to prevent headaches in a few weeks?

Comment 10

[Kim Moir [:kmoir] ET]

yes please

Comment 11

[Andrew Swan [:aswan]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/b7b3534b69ec
http://hg.mozilla.org/releases/mozilla-beta/rev/7fe901752bb8