Closed Bug 1282568 Opened 4 years ago Closed 4 years ago

Failing add-ons in mozapps tests

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: andy+bugzilla, Assigned: andy+bugzilla)

References

Details

(Whiteboard: triaged)

Attachments

(1 file, 1 obsolete file)

There's two add-ons in mozapps tests that are failing tests, it looks like the tests relied on signing being turned off here:

https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/browser/browser_update.js#12

That's not going to work once the pref goes away.

I'll see if I can sign those two add-ons and remove that pref twiddling code.
Blocks: 1186522
Attached patch out.patch (obsolete) — Splinter Review
Sorry, I wasn't expecting to make any commits today and haven't got my ssh keys set up on this box so pushing to mozreview fails for me. I will remember to sync up those keys.

This is a really easy diff because its 2 lines and lots of binary.
Attachment #8765635 - Flags: review?(aswan)
Comment on attachment 8765635 [details] [diff] [review]
out.patch

Looks good to me, I started a try run though:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5dc28497bf6
Attachment #8765635 - Flags: review?(aswan) → review+
If the patch is okay, it will have to land on mozilla-beta as well as land on inbound etc to address the test failures that prevent us from enabling the preference to toggle installing unsigned addons.
Actually sign the correct add-ons this time.
Attachment #8765635 - Attachment is obsolete: true
Attachment #8765996 - Flags: review+
If this fixes the issue, could you please upload to beta so we can enable the signed preference again? You can use a=test-only since test changes don't need relman approval
Flags: needinfo?(aswan)
https://hg.mozilla.org/mozilla-central/rev/a8fcca075fde
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
reopening, this change need to land on m-b for bug 1186522
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Landed in beta, should this also go into aurora to prevent headaches in a few weeks?
Flags: needinfo?(aswan) → needinfo?(kmoir)
yes please
Flags: needinfo?(kmoir)
Whiteboard: triaged
http://hg.mozilla.org/releases/mozilla-aurora/rev/b7b3534b69ec
http://hg.mozilla.org/releases/mozilla-beta/rev/7fe901752bb8
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.