Closed Bug 1282590 Opened 4 years ago Closed 4 years ago

Update client.mk

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 50.0

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(3 files)

I intended to port the new postflight handling for universal builds (bug 1244446), but c-c's client.mk is way out of sync.

Here's some easier ports as a warmup (try was green).
Attachment #8765619 - Flags: review?(mkmelin+mozilla)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Attachment #8765620 - Flags: review?(mkmelin+mozilla)
Attachment #8765621 - Flags: review?(mkmelin+mozilla)
Some of these patches seem very familiar - see bug 1195258 for example
Heh, wontfixed 8 months ago due to the imminent c-c/m-c merge ;)
Comment on attachment 8765619 [details] [diff] [review]
Remove obsolete 'make depend' (port bug 911936)

Review of attachment 8765619 [details] [diff] [review]:
-----------------------------------------------------------------

I guess we might as well take these.
Attachment #8765619 - Flags: review?(mkmelin+mozilla) → review+
Attachment #8765620 - Flags: review?(mkmelin+mozilla) → review+
Attachment #8765621 - Flags: review?(mkmelin+mozilla) → review+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
I wonder if these broke my local builds. I don't have much exotic, just

ac_add_options --disable-optimize
ac_add_options --disable-debug

... and it was building fine with code from maybe two days ago.

0:15.29 In file included from /opt/comm-central/src/ldap/xpcom/src/nsLDAPConnection.cpp:28:0:
 0:15.29 /opt/comm-central/src/obj-x86_64-pc-linux-gnu/mail/dist/include/nsProxyRelease.h: In instantiation of ‘static void detail::ProxyReleaseChooser<true>::ProxyRelease(nsIEventTarget*, already_AddRefed<T>, bool) [with T = nsLDAPConnection]’:
 0:15.29 /opt/comm-central/src/obj-x86_64-pc-linux-gnu/mail/dist/include/nsProxyRelease.h:124:19:   required from ‘void NS_ProxyRelease(nsIEventTarget*, already_AddRefed<T>, bool) [with T = nsLDAPConnection]’
 0:15.29 /opt/comm-central/src/obj-x86_64-pc-linux-gnu/mail/dist/include/nsProxyRelease.h:156:18:   required from ‘void NS_ReleaseOnMainThread(already_AddRefed<T>, bool) [with T = nsLDAPConnection]’
 0:15.29 /opt/comm-central/src/ldap/xpcom/src/nsLDAPConnection.cpp:613:48:   required from here
 0:15.29 /opt/comm-central/src/obj-x86_64-pc-linux-gnu/mail/dist/include/nsProxyRelease.h:95:46: error: ‘nsISupports’ is an ambiguous base of ‘nsLDAPConnection’
 0:15.29      ProxyReleaseISupports(aTarget, ToSupports(aDoomed.take()), aAlwaysProxy);
 0:15.29                                               ^
 0:15.33
I think this is more a fallout of bug 1247972. I filed bug 1283552.
You need to log in before you can comment on or make changes to this bug.