Closed
Bug 1282592
Opened 8 years ago
Closed 8 years ago
Build failure in dom/base/nsDOMWindowUtils.cpp with MP4 support compiled out
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
Attachments
(1 file)
|
574 bytes,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
As reported by Tim on IRC:
dom/base/nsDOMWindowUtils.cpp:2301:11: error: ‘class RefPtr<mozilla::dom::Promise>’ has no member named ‘MaybeResolve’ promise.MaybeResolve(NS_LITERAL_STRING("No; Compiled without MP4 support."));
Looks as simple as changing promise.MaybeResolve to promise->MaybeResolve, but I don't have a non-MP4 build handy to verify right now.
|
Assignee | |
Comment 1•8 years ago
|
||
Trivial fix, tested locally.
|
||
Updated•8 years ago
|
Attachment #8765711 -
Flags: review?(cpearce) → review+
Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e30eb329b132 Fix compile error in nsDOMWindowUtils::GetSupportsHardwareH264Decoding when building without MP4 support. r=cpearce
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e30eb329b132
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•