1282599 - Pass test path instead of single element array for xpcshell code coverage.

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Greg Mierzwinski [:sparky]]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

Steps to reproduce:

Run code coverage on the xpcshell tests.


Actual results:

The 'test url' field of the resulting JSON file was returned as an array.


Expected results:

The 'test url' field should be a path as a string.

Comment 1

[Greg Mierzwinski [:sparky]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e1d1e5259e7

Comment 2

[Greg Mierzwinski [:sparky]]

Attachment: jscov_1467065364716.json

This is a JSON containing coverage info using the patch which changes the single element array to a single path.

Comment 3

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1282599 - Pass test path as a string to xpcshell coverage collector.

The test file path is now recorded by the coverage collector as a string rather than a single element array.

Review commit: https://reviewboard.mozilla.org/r/60922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60922/

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8765664 [details]
Bug 1282599 - Pass test path as a string to xpcshell coverage collector.

https://reviewboard.mozilla.org/r/60922/#review58022

Looks good. Thanks Greg.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ba92367903b
Pass test path as a string to xpcshell coverage collector. r=chmanchester

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ba92367903b