Closed Bug 1282599 Opened 7 years ago Closed 7 years ago

Pass test path instead of single element array for xpcshell code coverage.

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: sparky, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

Steps to reproduce:

Run code coverage on the xpcshell tests.


Actual results:

The 'test url' field of the resulting JSON file was returned as an array.


Expected results:

The 'test url' field should be a path as a string.
This is a JSON containing coverage info using the patch which changes the single element array to a single path.
The test file path is now recorded by the coverage collector as a string rather than a single element array.

Review commit: https://reviewboard.mozilla.org/r/60922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60922/
Attachment #8765664 - Flags: review?(cmanchester)
Attachment #8765664 - Flags: review?(cmanchester) → review+
Comment on attachment 8765664 [details]
Bug 1282599 - Pass test path as a string to xpcshell coverage collector.

https://reviewboard.mozilla.org/r/60922/#review58022

Looks good. Thanks Greg.
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ba92367903b
Pass test path as a string to xpcshell coverage collector. r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/3ba92367903b
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.