1282668 - Get rid of nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that we don't need nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE anymore since all widgets request selection changes in most cases and selection is queried every time by IMEContentObserver for caching the result of eQuerySelectedText. So, even if widget doesn't necessary, it's enough they ignore the notifications.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f65a21df3a8

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9eaa70a81a75

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7a03e2158d1

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1282668 Get rid of nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE

Currently, all widgets request selection change notifications to IMEContentObserver.  Additionally, IMEContentObserver needs to listen selection changes for caching latest selection for eQuerySelectedText.  Therefore, it doesn't make sense to keep defining nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE.

If widgets didn't need selection change notifications, they could just ignore the unnecessary notifications.

Note that all widgets don't need selection change notifications if a plugin has focus and IMEContentObserver cannot observe selection changes in the plugin.  Therefore, if IMEContentObserver is initialized with a plugin, it shouldn't listen selection changes (and doesn't need to notify widgets of selection changes).

Review commit: https://reviewboard.mozilla.org/r/61004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61004/

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8765816 [details]
Bug 1282668 Get rid of nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE

https://reviewboard.mozilla.org/r/61004/#review58042

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/456eeed13f87
Get rid of nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE r=m_kato

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/456eeed13f87