Get rid of nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE

RESOLVED FIXED in Firefox 50

Status

()

Core
Widget
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod})

Trunk
mozilla50
inputmethod
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

I think that we don't need nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE anymore since all widgets request selection changes in most cases and selection is queried every time by IMEContentObserver for caching the result of eQuerySelectedText. So, even if widget doesn't necessary, it's enough they ignore the notifications.
Created attachment 8765816 [details]
Bug 1282668 Get rid of nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE

Currently, all widgets request selection change notifications to IMEContentObserver.  Additionally, IMEContentObserver needs to listen selection changes for caching latest selection for eQuerySelectedText.  Therefore, it doesn't make sense to keep defining nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE.

If widgets didn't need selection change notifications, they could just ignore the unnecessary notifications.

Note that all widgets don't need selection change notifications if a plugin has focus and IMEContentObserver cannot observe selection changes in the plugin.  Therefore, if IMEContentObserver is initialized with a plugin, it shouldn't listen selection changes (and doesn't need to notify widgets of selection changes).

Review commit: https://reviewboard.mozilla.org/r/61004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61004/
Attachment #8765816 - Flags: review?(m_kato)
Comment on attachment 8765816 [details]
Bug 1282668 Get rid of nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE

https://reviewboard.mozilla.org/r/61004/#review58042
Attachment #8765816 - Flags: review?(m_kato) → review+

Comment 6

2 years ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/456eeed13f87
Get rid of nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE r=m_kato

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/456eeed13f87
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.