1282681 - 'Your mercurial account has been disabled' message contains funky whitespace

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[:glob ✱]

https://github.com/mozilla/version-control-tools/blob/master/hgserver/pash/pash.py#L55

the output is:

$ ssh hg.mozilla.org
Your mercurial account has been disabled due                           to inactivity.
Please file a bug at                           https://bugzilla.mozilla.org (or                           http://tinyurl.com/njcfhma) to re-activate                           your account.
Connection to hg.mozilla.org closed.


<timeless> yeah, that works exactly as well as it appears to work :)

Comment 1

[:glob ✱]

Attachment: pash: fix poor formatting of 'account disabled' message (bug 1282681);

Review commit: https://reviewboard.mozilla.org/r/60980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60980/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8765753 [details]
pash: fix poor formatting of 'account disabled' message (bug 1282681);

https://reviewboard.mozilla.org/r/60980/#review57864

We surprisingly doesn't have a test for this code path :(

If you are feeling bold, tests for pash live in hgserver/. But don't let that hold up landing this.

Comment 3

[:glob ✱]

(In reply to Gregory Szorc [:gps] from comment #2)
> If you are feeling bold, tests for pash live in hgserver/. But don't let
> that hold up landing this.

i was, but my local env didn't feel up to playing that game today (all tests are 'skipped' without reason or errors logged), so i'm just going to land as-is.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/a1c0fe9f5d87
pash: fix poor formatting of 'account disabled' message ; r=gps

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/946e1d2e857c
hgserver: add test coverage for hg account being disabled