1282691 - Assertion failure: !IsWaitingToPause(aAnimation) (Animation is already waiting to pause)

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P3)

Description

[Jesse Ruderman]

Attachment: testcase

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Jesse Schwartzentruber (:truber)]

Testcase still asserts in mozilla-central 20170216-25929185c467

Comment 3

[Jesse Schwartzentruber (:truber)]

Testcase in comment 0 still asserts in m-c rev 20171011-2a5927f33f83.

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

I suspect we're returning true from Animation::IsPossiblyOrphanedPendingAnimation because we're pause-pending but have no document.

Then, a few moments later, we're re-attached to the same document whose pending animation tracker has us registered as a pause-pending animation. However, our local pending state is "not pending" so we don't go and remove ourselves from the pending animation tracker as part of the CancelPendingTasks() step in the call to play().

So it sounds like we should replace the assertion with a step that removes us from the pause pending set. That's an extra hashtable lookup which is unfortunate but it's probably the best we can do.

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7626d8f977f35ac7ca34617eceafe98d866d3af

Comment 6

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1282691 - Drop the assertion about an animation that we're making play-pending not already being pause-pending;

We could handle this case by dropping the animation from the pause-pending table
but that's an extra hashtable lookup that so far seems to be unnecessary.

I have verified that the crashtest added in this patch fails without the code
changes included here.

Review commit: https://reviewboard.mozilla.org/r/189014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189014/

Comment 7

[Boris Chiou [:boris]]

Comment on attachment 8918158 [details]
Bug 1282691 - Drop the assertion about an animation that we're making play-pending not already being pause-pending;

https://reviewboard.mozilla.org/r/189014/#review194332

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe68b3629d17
Drop the assertion about an animation that we're making play-pending not already being pause-pending; r=boris

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fe68b3629d17