|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Testcase still asserts in mozilla-central 20170216-25929185c467
Testcase in comment 0 still asserts in m-c rev 20171011-2a5927f33f83.
I suspect we're returning true from Animation::IsPossiblyOrphanedPendingAnimation because we're pause-pending but have no document. Then, a few moments later, we're re-attached to the same document whose pending animation tracker has us registered as a pause-pending animation. However, our local pending state is "not pending" so we don't go and remove ourselves from the pending animation tracker as part of the CancelPendingTasks() step in the call to play(). So it sounds like we should replace the assertion with a step that removes us from the pause pending set. That's an extra hashtable lookup which is unfortunate but it's probably the best we can do.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Comment on attachment 8918158 [details] Bug 1282691 - Drop the assertion about an animation that we're making play-pending not already being pause-pending; https://reviewboard.mozilla.org/r/189014/#review194332
Attachment #8918158 - Flags: review?(boris.chiou) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/fe68b3629d17 Drop the assertion about an animation that we're making play-pending not already being pause-pending; r=boris
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
status-firefox50: affected → ---
status-firefox56: --- → wontfix
status-firefox57: --- → wontfix
status-firefox-esr52: --- → wontfix
You need to log in before you can comment on or make changes to this bug.