Closed
Bug 1282713
Opened 8 years ago
Closed 8 years ago
Merge local/remote test cases of bug 1069772 and bug 1271240
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: freesamael, Assigned: freesamael)
Details
(Whiteboard: btpp-active)
Attachments
(1 file, 1 obsolete file)
|
15.56 KB,
patch
|
freesamael
:
review+
|
Details | Diff | Splinter Review |
According to the discussion on m.d.p. [1], I have misunderstood the meaning of e10s mode in mochitest-chrome. I thought only if running in e10s mode it can use <browser remote="true">, while it turns out the --e10s or --disable-e10s flags for mochitest-chrome only decides whether new tabs are opened in remote, and we do be able to use <browser remote="true"> without running in e10s mode. We should merge the local / remote test cases of bug 1069772 and bug 1271240 accordingly. [1] https://groups.google.com/d/msg/mozilla.dev.platform/9CApTDxrQ6M/K53BIajYAAAJ
|
Assignee | |
Updated•8 years ago
|
Summary: Merge local/remote test cases of bug 1069772 and 1271240 → Merge local/remote test cases of bug 1069772 and bug 1271240
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → sawang
|
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4afc1e553dd8c167b7fc5197623e8d9b5f7395a2
|
||
Updated•8 years ago
|
Whiteboard: btpp-active
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8766233 [details] [diff] [review] Merge test cases Hi Olli, This is a simple patch to merge the local / remote test cases in bug 1069772 and bug 1271240 as it turns out without running in e10s mode we can still use <browser remote="true">. Since there's no more --e10s flag and mochitest-chrome doesn't run in e10s mode by default either, I think merging the test cases should be better.
Attachment #8766233 -
Flags: review?(bugs)
|
||
Updated•8 years ago
|
Attachment #8766233 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3595a6ce6bd
|
|
Assignee | |
Comment 5•8 years ago
|
||
Should not run on Android due to absence of e10s.
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8766233 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8767855 -
Attachment description: Merge test cases → Merge test cases. r=smaug
Attachment #8767855 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2456ca84d072 Merge local/remote test cases of bug 1069772 and bug 1271240. r=smaug
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2456ca84d072
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•