1282714 - "Delete from History" and "Dismiss" options are no longer available in the "..." context menu from Activity Stream Timeline History and New Tab pages, for a bookmarked item

Status: VERIFIED FIXED

(Firefox Graveyard :: Activity Streams: General, defect)

Description

[Vlad Bacia-Mociran [:VladB]]

Attachment: missing delete option

Affected versions]:
- Firefox 45.0 and up
- Activity Stream v1.1.0

[Affected Platforms]:
- All Windows
- All Linux
- All Mac OS

[Prerequisites]:
- Latest Activity Stream add-on (v1.1.0-dev) was previously installed on a profile.
- Have enough history so that the "Top Sites", "Highlights", "History" areas are populated with visited websites.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Click the Activity Stream button from the browser toolbar.
3. Hover a Highlights tile and click on "..." context menu button.
4. Click on "Bookmark" button.
5. Hover again the previously bookmarked Highlights tile and click on "..." context menu button.
6. Observe the options displayed.

[Expected result]:
- "Delete from History" and "Dismiss" options are displayed in the context menu for the bookmarked website.

[Actual result]:
- After a website is bookmarked the "Delete from History" and "Dismiss" options are no longer available in Activity Stream Timeline History and New Tab pages.

[Notes]:
- This issue has appear after fixing Bug 1280457.
- This issue is reproducible in Activity Stream Timeline History page and Activity Stream New Tab page, for items from "Top Sites", "Highlights" and "History" areas, that were bookmarked.
- Attached a screen recording of the issue.

Comment 1

[Vlad Bacia-Mociran [:VladB]]

Filed in GitHub https://github.com/mozilla/activity-stream/issues/887

Comment 2

[Vlad Bacia-Mociran [:VladB]]

via https://github.com/mozilla/activity-stream/pull/889/commits/2df5cedb98d2c91f123b5b461d139dd92f6b02dd

Comment 3

[Vlad Bacia-Mociran [:VladB]]

This issue has been verified on Win 8.1 x64, Mac OS X 10.11 and Ubuntu 14.04 x64 with latest Nightly 50.0a1 (Build ID: 20160628030238) using latest Activity Stream v1.1.0-custom build and could not reproduce it.
Thus, marking this issue as Verified-Fixed.