1282722 - Add SetSeekThreshold for VPXDecoder

Status: NEW

(Core :: Audio/Video: Playback, defect, P3)

Description

[Alfredo Yang (:alfredo)]

Add SetSeekThreshold for VPXDecoder to increase seek performance.

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: Bug 1282722: add seek target threshold for VPX decoder.

Review commit: https://reviewboard.mozilla.org/r/60996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60996/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

https://reviewboard.mozilla.org/r/60996/#review58024

::: dom/media/platforms/agnostic/VPXDecoder.cpp:95
(Diff revision 1)
>  nsresult
>  VPXDecoder::Flush()
>  {
>    MOZ_ASSERT(mCallback->OnReaderTaskQueue());
>    mIsFlushing = true;
> -  nsCOMPtr<nsIRunnable> r = NS_NewRunnableFunction([this] () {
> +  RefPtr<VPXDecoder> self = this;

Why needing to change capture of |this| to |self|?

Comment 3

[Alfredo Yang (:alfredo)]

https://reviewboard.mozilla.org/r/60996/#review58024

> Why needing to change capture of |this| to |self|?

Because this lambda running in a task queue, it needs to take reference to keep VPXDecoder alive.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

https://reviewboard.mozilla.org/r/60996/#review58024

> Because this lambda running in a task queue, it needs to take reference to keep VPXDecoder alive.

It is safe to take the raw pointer because Flush() will not return until SynRunnable is finished.

Comment 5

[Alfredo Yang (:alfredo)]

Comment on attachment 8766125 [details]
Bug 1282722: add seek target threshold for VPX decoder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60996/diff/1-2/

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8766125 [details]
Bug 1282722: add seek target threshold for VPX decoder.

https://reviewboard.mozilla.org/r/60996/#review58066

::: dom/media/platforms/agnostic/VPXDecoder.cpp:96
(Diff revision 2)
>  VPXDecoder::Flush()
>  {
>    MOZ_ASSERT(mCallback->OnReaderTaskQueue());
>    mIsFlushing = true;
>    nsCOMPtr<nsIRunnable> r = NS_NewRunnableFunction([this] () {
> -    // nothing to do for now.
> +    this->mSeekTargetThreshold.reset();

You can save |this->|.

Comment 7

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3

Comment 8

[Release mgmt bot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.