1282763 - Tab Tray Menu is misplaced on rotation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Open Firefox in portrait
2. Open the tab tray 
3. Tap the 3 dots button near the "+" button
4. Rotate from portrait to landscape

Expected results:
- "New Private Tab" and "Close all Tabs" dialog is displayed over the "+" and 3 dots button

Actual results:
- "New Private Tab" and "Close all Tabs" dialog is displayed under the header

Comment 1

[Tom Klein]

Attachment: Bug 1282763 - Wait for anchor to display before reanchoring tabs menu.

Review commit: https://reviewboard.mozilla.org/r/96612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96612/

Comment 2

[Tom Klein]

I don't expect this is high priority, but I was just in the TabsPanel code, so ... here it is.  I wonder if something similar is going on in bug 1318672.

Comment 3

[Tom Klein]

Comment on attachment 8815835 [details]
Bug 1282763 - Wait for anchor to display before reanchoring tabs menu.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96612/diff/1-2/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8815835 [details]
Bug 1282763 - Wait for anchor to display before reanchoring tabs menu.

https://reviewboard.mozilla.org/r/96612/#review99392

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/073efe219a15
Wait for anchor to display before reanchoring tabs menu. r=sebastian

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/073efe219a15

Comment 7

[Sylvestre Ledru [:Sylvestre]]

We will let it ride the trains.

Comment 8

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed in Nightly build 53.0a1 2017-01-09;
Devices: 
-Asus ZenPad (Android 6.0.1);
-LG G4 Android  5.1;
-Lenovo A536 Android 4.4.2.