1282801 - Budget Request Voting has been retriggered even though no flags are set

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Michael Kohler [:mkohler]]

For https://bugzilla.mozilla.org/show_bug.cgi?id=1279968 there were flags set for the voting, but they were removed in the bug after the first voting was created. Further Konstantina deleted the voting on the portal.

Now Konstantina has updated the bug with a comment, this triggered the whole Budget Voting process again. Tasos, could you please investigate this? Is this because we have deleted it from the portal? If so, can we make sure that it only retriggers if the correct flags are set?

Triggered voting page: https://reps.mozilla.org/v/budget-request-michael-kohler-https-reps-mozilla-org-e-mozilla-tech-weekend-iot-edition/

Comment 1

[Tasos Katsoulas [:tasos]]

The problem here is that the bug is also saved in the db. Additionally to the deletion of the poll, the bug must be removed from the db in order to avoid the re-creation of the poll. I am going to mark this bug as invalid. Please let me know if you want to remove the poll and bug from the portal.

Comment 2

[Michael Kohler [:mkohler]]

Hi tasos, we deleted the bug through the portal voting GUI. This should definitely remove the bug from the DB as well, otherwise that functionality is basically useless. Is this possible?

On that note, please remove the "Michael Kohler" budget request voting from the portal for now in that case: https://reps.mozilla.org/v/budget-request-michael-kohler-https-reps-mozilla-org-e-mozilla-tech-weekend-iot-edition/

Comment 3

[Tasos Katsoulas [:tasos]]

The delete button in the voting UI is deleting the polls and not the bugs in the DB. The bugs are not serving only the voting app and I am not sure that a cascade delete (through the poll) is the best option. Either way, I am assigning myself to this bug to investigate further how we can proceed with this. 

Regarding the specific budget request and the relevant poll, both have been manually deleted for now.

Comment 4

[Tasos Katsoulas [:tasos]]

PR has been opened here:
https://github.com/mozilla/remo/pull/1213

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/91f45eaaa054f9ac995bd0bcf6e57f2a8d3e7583
[fix bug 1282801] Delete bug when deleting a budget request poll.

https://github.com/mozilla/remo/commit/857f768bddd7d0e2197d0fb74ec21d1a6e9bbe56
Merge pull request #1213 from akatsoulas/1282801-delete-voting-bug

[fix bug 1282801] Delete bug when deleting a budget request poll.

Comment 6

[Tasos Katsoulas [:tasos]]

Verified on stage that if a poll is linked to a bug (budget polls) and an admin user triggers a delete, then both the poll and the bug are deleted.