1282810 - Debug builds have incorrect LIR/MIR locations and might report bailouts on goto.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Nicolas B. Pierron [:nbp] {away}]

The problem comes from the recent addition of the eager bailing mode, which makes us encode the snapshots before we use the visitor to visit the instruction.

The problem is that the snapshot encoding stores information about the last visited instruction.  Thus, if the first instruction of the basic block is a bailing instruction, then the debug information will report information about the conditional of the last encoded block.

Comment 1

[Nicolas B. Pierron [:nbp] {away}]

Attachment: Register instruction information before encoding snapshots.

setElement is normally called by the accept function, but as this code has
to be executed before we call the accept function (because we need to have
the entry register allocation), we have to call it manually to satisfy the
use of the "instruction()" method in
"CodeGeneratorShared::encode(LSnapshot*)"

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ffe64c98d40
Register instruction information before encoding snapshots. r=h4writer

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ffe64c98d40