Closed Bug 1282868 Opened 4 years ago Closed 4 years ago

devtools tests failing with add-on signing failures

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Iteration:
50.2 - Jul 4
Tracking Status
firefox48 --- affected
firefox49 --- affected
firefox50 --- fixed

People

(Reporter: andy+bugzilla, Assigned: andy+bugzilla)

References

Details

(Whiteboard: triaged)

Attachments

(1 file, 1 obsolete file)

Failing tests:

https://irccloud.mozilla.com/pastebin/vtKKsk4y

Example:

https://treeherder.mozilla.org/logviewer.html#?job_id=1231974&repo=mozilla-beta#L2856

 14:45:09     INFO -  1467063909772	addons.xpi	WARN	Download of http://example.com/browser/devtools/client/debugger/test/mochitest/addon3.xpi failed: signature verification failed

Causes:

 14:45:55     INFO -  206 INFO TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addon-panels.js | Test timed out -
1
Blocks: 1186522
Depends on: 1281114
Attached patch resigned.patch (obsolete) — Splinter Review
For this I took the new addon from bug 1281114, bumped the version to 0.4 and resigned it through AMO.
Attachment #8766016 - Flags: review?(aswan)
There are still failing tests in the new try run (dt2 and dt5)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11d1f8e6095c&selectedJob=23065085

Looking at the logs
dt2
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/5105dc6c152957d485a5893d9c2b3f4a3f0610cec0e8665557a3bd3529b2a348b95c74ee9bd9c44de75ac946bb6a7ecd40ffc3d42f6b4c1e21bf845cb8b51f06

I see things like 
{"source": "mochitest", "process": "Main app process", "thread": "MainThread", "time": 1467157609443, "action": "process_start", "pid": 1887}
{"thread": "ProcessReader", "level": "info", "pid": 1887, "source": "mochitest", "time": 1467157610701, "action": "log", "exc_info": false, "message": "1467157610698\taddons.xpi\tWARN\tRefusing to install staged add-on mozscreenshots@mozilla.org with signed state 0"}

dt5
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/39ecb4a742458511cf5b47d1f8d9c706e33b287477917ce3453aff2781a9c384c0d319360c6c02496a056a62e6965277fcd089ca7ac1eb6f8c71351a07889803

{"source": "mochitest", "process": "Main app process", "thread": "MainThread", "time": 1467157946631, "action": "process_start", "pid": 26451}
{"thread": "ProcessReader", "level": "info", "pid": 26451, "source": "mochitest", "time": 1467157948649, "action": "log", "exc_info": false, "message": "1467157948642\taddons.xpi\tWARN\tRefusing to install staged add-on mozscreenshots@mozilla.org with signed state 0"}

but these are starred with an intermittent orange so perhaps someone who is more familiar with the tests could comment
Flags: needinfo?(aswan)
I remember ahal looking at stuff around mozscreenshot, when we did this a few months ago?
Flags: needinfo?(ahalberstadt)
The mozscreenshots messages are warnings, they aren't test failures.  I think all the starred failures look just like bug 1268269?
Flags: needinfo?(aswan)
Okay, I just wanted to make sure.  I'm not familiar with the tests -  I was just looking through the logs for issues with messages related to signed addons.  If this patch gets reviewed and landed, and the tests pass on inbound could we get it landed on beta as well?  I would like to renable the signing preference for beta again.  You can use a=test-only on beta since relman doesn't need to approve test changes.
Mozscreenshots used to be working.. is it possible that if the prefs were off a developer made a change and re-zipped the .xpi without signing? If signing was disabled this whole time I wouldn't be surprised if a bunch of addons got checked in/updated that now need to be signed again.
Flags: needinfo?(ahalberstadt)
Attachment #8766016 - Attachment is obsolete: true
Attachment #8766016 - Flags: review?(aswan)
Attachment #8766419 - Flags: review+
Assignee: nobody → amckay
Iteration: --- → 50.2 - Jul 4
Whiteboard: triaged
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8766419 [details]
bug 1282868 re-sign devtools test addon  a=test-only

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61320/diff/1-2/
Attachment #8766419 - Attachment description: bug 1282868 re-sign devtools test addon → bug 1282868 re-sign devtools test addon a=test-only
Attachment #8766419 - Flags: review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9df340975764
re-sign devtools test addon r=me a=test-only
This isn't in central yet but should get there soon.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/9df340975764
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.