1282870 - input.webkitdirectory doesn't work

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Dietrich Ayala (:dietrich)]

This feature added in bug 1258489 for compat, but is non-functional.

Comment 1

[Dietrich Ayala (:dietrich)]

Using Nightly 50.0a1 (2016-06-28) and Addy Osmani's sample at http://jsfiddle.net/addyo/Ha979/ I got the following results:

* File picker only picks files, not directories, which seems like the opposite of the expected behavior. Chrome doesn't allow file picking, only directories (which perhaps is a bug... https://bugs.chromium.org/p/chromium/issues/detail?id=59818).

* Dropping a directory onto the <input> lists the directory name, not the files contained within. Chrome lists the files contained within the dropped directory, but not the directory itself.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

webkitdirectory is not enabled by default, so did you actually enable the pref dom.webkitBlink.dirPicker.enabled?
webkitdirectory implementation is still missing stuff like form submission, though that is about to land.

Comment 3

[Dietrich Ayala (:dietrich)]

Yes, see my final comment from bug 1258489.

Perhaps I have done something wrong. I'm continually told in bugs I report that I must not be seeing what I'm seeing. I'd prefer to be incorrect ;) You can try the URL above for yourself, it's quite simple to test there.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: fix.patch

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Dietrich Ayala (:dietrich) from comment #3)
 
> Perhaps I have done something wrong. I'm continually told in bugs I report
> that I must not be seeing what I'm seeing. I'd prefer to be incorrect ;) You
> can try the URL above for yourself, it's quite simple to test there.
Hah. It wasn't just clear from this bug report that the pref was enabled :)

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8766214 [details] [diff] [review]
fix.patch

Isn't the issue that we don't handle webkitdirectory attribute in nsFileControlFrame::CreateAnonymousContent

Comment 7

[Andrea Marchesini [:baku]]

Attachment: fix.patch

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8766252 [details] [diff] [review]
fix.patch

Could you cache pref values in some bool
bool isDir =
  Preferences::GetBool("dom.input.dirpicker", false) &&
  content && content->HasAttr(kNameSpaceID_None, nsGkAtoms::directory);;
bool isWebkitDir = isDir ? false :   
  Preferences::GetBool("dom.webkitBlink.dirPicker.enabled", false) &&
  content && content->HasAttr(kNameSpaceID_None, nsGkAtoms::webkitdirectory);

and then use the bool vars and not check the pref in many places.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f843a97323da
HTMLInputElement.webkitdirectory should show a DirPicker, r=smaug

Comment 10

[Carsten Book [:Tomcat]]

bustage and backedout -> https://treeherder.mozilla.org/logviewer.html#?job_id=30884007&repo=mozilla-inbound

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72993ec9d303
Backed out changeset f843a97323da for bustage on a CLOSED TREE

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c839b37704c
HTMLInputElement.webkitdirectory should show a DirPicker, r=smaug

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5c839b37704c

Comment 14

[Jean-Yves Perrier [:teoli]]

In order to update the docs, if I understand correctly both HTMLInputElement.webkitdirectory and file.webkitrelativepath work only in Gecko50+ instead of Gecko49.

Are there any plan to uplift this to Gecko49? (Not that I want too, just to foresee what doc update is needed)

Comment 15

[Andrea Marchesini [:baku]]

We don't want uplift this patch. And everything is disabled by pref. We want to enable this feature when the Entries API is fully implemented. See bug 1284987.