1282881 - Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Claas Augner [:claas]]

Background:
The userpref `browser.zoom.full` was added to environment telemetry in Firefox 50 (Bug 979323).

Goal of this bug:
Remove the userpref from environment telemetry again in Firefox 53.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Nightly is now on 53: http://whattrainisitnow.com/

Claas, do you want to take this?

Comment 2

[Claas Augner [:claas]]

Georg, thanks for the ping, I gladly take this.

Comment 3

[Claas Augner [:claas]]

Attachment: Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53

Comment 4

[Claas Augner [:claas]]

Comment on attachment 8816578 [details] [diff] [review]
Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53

I have reversed the changes [0] from Bug 979323.

[0] https://bugzilla.mozilla.org/attachment.cgi?id=8765186

Comment 5

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8816578 [details] [diff] [review]
Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53

Review of attachment 8816578 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/docs/data/environment.rst
@@ -323,5 @@
>  - ``browser.urlbar.suggest.searches``: True if search suggestions are enabled in the urlbar. Defaults to false.
>  
>  - ``browser.urlbar.userMadeSearchSuggestionsChoice``: True if the user has clicked Yes or No in the urlbar's opt-in notification. Defaults to false.
>  
> -- ``browser.zoom.full``: True if zoom is enabled for both text and images, that is if "Zoom Text Only" is not enabled. Defaults to true. Collection of this preference has been enabled in Firefox 50 and will be disabled again in Firefox 53 (`Bug 979323 <https://bugzilla.mozilla.org/show_bug.cgi?id=979323>`_).

We don't have a great approach yet on how to document environment data points that were removed again for future data investigations.
Can we leave this in for now as:

> - ``browser.zoom.full`` (deprecated): was enabled in ... and was disabled in ...

Comment 6

[Claas Augner [:claas]]

Attachment: Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53

Comment 7

[Claas Augner [:claas]]

Attachment: Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53

Comment 8

[Claas Augner [:claas]]

Comment on attachment 8818357 [details] [diff] [review]
Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53

Remove pref from TelemetryEnvironment, but keep updated version of data point documentation.

PS: For the sake of readability, I chose a more concise wording, omitting the enable/disable terms.

Comment 9

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8818357 [details] [diff] [review]
Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53

Review of attachment 8818357 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c4def343fe
Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53. r=gfritzsche

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c4c4def343fe