Closed
Bug 1282882
Opened 8 years ago
Closed 8 years ago
Remove LoadContextInfo and LoadContext PB Flags
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: jandreou25, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
21.73 KB,
patch
|
jdm
:
review+
mayhemer
:
review+
|
Details | Diff | Splinter Review |
Removing LoadContextInfo PB flags and replacing with new OriginAttribute.
|
Reporter | |
Updated•8 years ago
|
Summary: Remove LoadContextInfo PB Flags → Remove LoadContextInfo and LoadContext PB Flags
|
|
Reporter | |
Comment 1•8 years ago
|
||
Attachment #8766028 -
Flags: review?(josh)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8766028 [details] [diff] [review] Bug1282882.patch Review of attachment 8766028 [details] [diff] [review]: ----------------------------------------------------------------- ::: netwerk/base/LoadContextInfo.cpp @@ -70,4 @@ > NS_IMETHODIMP LoadContextInfoFactory::GetPrivate(nsILoadContextInfo * *aPrivate) > { > NeckoOriginAttributes attrs; > - attrs.SyncAttributesWithPrivateBrowsing(aPrivate); ...oops. @@ +128,4 @@ > > NeckoOriginAttributes oa; > NS_GetOriginAttributes(aChannel, oa); > + oa.SyncAttributesWithPrivateBrowsing(pb); This should be an assert instead. ::: netwerk/test/unit/test_bug248970_cache.js @@ +47,5 @@ > asyncOpenCacheEntry(entries[store_idx][0], > entries[store_idx][2], > Ci.nsICacheStorage.OPEN_TRUNCATE, > + LoadContextInfo.custom(false, > + {privateBrowsingId : !entries[store_idx][3]}), We should choose a 0 or 1 value instead of relying on conversion from boolean. @@ +88,5 @@ > asyncOpenCacheEntry(entries[check_idx][0], > entries[check_idx][2], > Ci.nsICacheStorage.OPEN_READONLY, > + LoadContextInfo.custom(false, > + {privateBrowsingId : !entries[check_idx][3]}), Same.
Attachment #8766028 -
Flags: review?(josh) → review+
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8766028 -
Flags: review?(honzab.moz)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8766028 [details] [diff] [review] Bug1282882.patch Review of attachment 8766028 [details] [diff] [review]: ----------------------------------------------------------------- lgtm.
Attachment #8766028 -
Flags: review?(honzab.moz) → review+
|
|
Reporter | |
Updated•8 years ago
|
Assignee: jandreou25 → nobody
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b2b90d326543 Remove LoadContextInfo and LoadContext private browsing flags; r=jdm,mayhemer
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b2b90d326543
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
Assignee | |
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•