1282905 - (webext-port-save-to-pocket) Implement missing WebExtension functionality for the Save To Pocket extension

Status: RESOLVED WONTFIX

(WebExtensions :: Compatibility, defect, P5)

Description

[Matthew Wein [:mattw]]

Firefox testing link: https://addons.allizom.org/en-US/firefox/addon/save-to-pocket-ica-test/

Chrome store link: https://chrome.google.com/webstore/detail/save-to-pocket/niloccemoadcdkdjlinkgdfekeahmflj

Manifest Errors:
- Error processing update_url
- Error processing options_page
- Signature Verification Error: the signature on this .jar archive is invalid because the certificate used to sign this file has an unrecognized issuer.

Missing API methods:
- chrome.app.getDetails

Comment 1

[Matthew Wein [:mattw]]

chrome.app.getDetails() is undocumented and deprecated, and there are no other uses of chrome.app in this extension.

Comment 2

[Andy McKay]

This is based on looking at the Chrome extension, but I think Shane you've been looking at the Firefox one. I don't think we'll be implementing chrome.app.getDetails so there isn't much to do with this bug.

Comment 3

[Shane Caraveo (:mixedpuppy)]

The chrome extension has some issues we'd have to address, I think it's better to port the firefox extension.  Off the top of my head these are the issues we might run into porting to a webextension:


- Firefox accounts integration (may require moz-ext redirection, but maybe it would work with the identity api, or maybe it is a non-issue)
- context menu opening panel
- bookmarks button menu and bookmarks top menu items
- existing pocket library files working in sandbox (probably needs changes)
- disabling via pref since it's a system addon
- localization via pontoon (not sure if that works with webextensions)
- reader mode integration
- disabling old pocket addon (probably not necessary any longer)
- disabling old socialapi integration (probably not necessary any longer)

That is not to say all these MUST be done, we could decide to change some things or that some are not necessary.

Comment 4

[Shane Caraveo (:mixedpuppy)]

- persisting button location when moving from bootstrap to webextension.

Comment 5

[Kris Maglione [:kmag]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #3)
> - Firefox accounts integration (may require moz-ext redirection, but maybe
> it would work with the identity api, or maybe it is a non-issue)

Supporting this via the identity API sounds like a good idea, if it isn't
already supported.

> - context menu opening panel

That's bug 1318791.

> - bookmarks button menu and bookmarks top menu items

This is similar to bug 1268020. We should probably implement this using a
similar API, but possibly restrict it to system add-ons at first.

> - disabling via pref since it's a system addon

I think we should handle this at the platform level.

> - localization via pontoon (not sure if that works with webextensions)

We can always convert between property files and locale JSON files without too
much trouble, if we can't just add support to Pontoon.

> - reader mode integration

Can you file a bug explaining what's needed for this in more detail, or add a
comment to bug 1286387?

> - persisting button location when moving from bootstrap to webextension.

Can you file a bug for that?

Comment 6

[Shane Caraveo (:mixedpuppy)]

(In reply to Kris Maglione [:kmag] from comment #5)
> (In reply to Shane Caraveo (:mixedpuppy) from comment #3)
> > - Firefox accounts integration (may require moz-ext redirection, but maybe
> > it would work with the identity api, or maybe it is a non-issue)
> 
> Supporting this via the identity API sounds like a good idea, if it isn't
> already supported.

fxa oauth is locked down, so I think the only way to use it is via the modules in firefox (which the pocket addon uses).  It also may be an idea to implement the google specific APIs in identity, but backended by fxa.  ni rfkelly for input here.

> > - disabling via pref since it's a system addon
> 
> I think we should handle this at the platform level.

It can stick in the hybrid bootstrap at first.

> > - persisting button location when moving from bootstrap to webextension.
> 
> Can you file a bug for that?

Already have it in bug 1311500

Comment 7

[Ryan Kelly [:rfkelly]]

> fxa oauth is locked down, so I think the only way to use it is via the modules in firefox
> (which the pocket addon uses).

I don't recall existing pocket integrations doing anything too fancy.  Do you want to automagically use the logged-in state of sync in the browser, or manage some separate login state here?

> It also may be an idea to implement the google specific APIs in identity, but backended by fxa. 

I'd be quite interested in this for 2017, as we're exploring new ways to add value with a Firefox Account.  Could you link me to the relevant docs and I'll take a look?  Also, /cc :adavis who is the product manager for FxA.

Comment 8

[Shane Caraveo (:mixedpuppy)]

> > It also may be an idea to implement the google specific APIs in identity, but backended by fxa. 
> 
> I'd be quite interested in this for 2017, as we're exploring new ways to add
> value with a Firefox Account.  Could you link me to the relevant docs and
> I'll take a look?  Also, /cc :adavis who is the product manager for FxA.

I've cc'd you both on bug 1320862

Comment 9

[Alex Davis [:adavis]]

Adding Vlad since he made some progress on this on the FxA side.

Comment 10

[Shane Caraveo (:mixedpuppy)]

Based on a recent conversation, my understanding is that the current webextension on chrome will be migrated rather than trying to update the old legacy addon.  As such I'm closing this, if specific issues come up new bugs can be posted.